Skip to content

Haml broken -> haml fixed #193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
rubydesign opened this issue Dec 17, 2022 · 2 comments
Closed

Haml broken -> haml fixed #193

rubydesign opened this issue Dec 17, 2022 · 2 comments
Assignees
@jaredcwhite

Comments

@rubydesign
Copy link
Collaborator

rubydesign commented Dec 17, 2022 •
edited
Loading

Hi,
like i said i am starting to code again with ruby2js, and found the haml filter got outdated. Even test failing.

So i dug a little and the haml architecture has changed a bit (as i guess ruby2js), but i got it updated. And the tests fixed.

I am not sure if i am allowed to push, git gave me the ssh option.
Anyway, i wanted to ask before doing that,. The only two affected files are the

  • ruby2js/haml
  • spec/haml_spec

Since they were broken i hope it's not a problem
@rubydesign
Copy link
Collaborator Author

@jaredcwhite I pushed to a branch now, haml_fix .For you to have a look and also just to see if i really have push rights.

https://github.com/ruby2js/ruby2js/compare/haml_fix

It really is only those two files I can create a pr for it if you think that would be good.

I just made a new wiki page to describe my workflow, and it does rely on this.

Thanks for continuing the work.

@jaredcwhite jaredcwhite self-assigned this Dec 20, 2022
@jaredcwhite
Copy link
Member

jaredcwhite commented Jan 30, 2023 •
edited
Loading

@rubydesign I don't have much experience with Haml, but this seems like an improvement so LGTM! #198

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jaredcwhite jaredcwhite

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rubydesign @jaredcwhite