Skip to content

Default parameters should not be copied on super calls #212

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
esb opened this issue Apr 28, 2024 · 0 comments · Fixed by #215
Closed

Default parameters should not be copied on super calls #212

esb opened this issue Apr 28, 2024 · 0 comments · Fixed by #215

Comments

@esb
Copy link

esb commented Apr 28, 2024

The default parameters are incorrectly included on a super call.

def  _render(force = false, options = {}) 
  super
end

This generates

_render(force = false, options = {}) {
  super._render(force = false, options = {});
}

Clearly, that's not a good result! It should be -

_render(force = false, options = {}) {
  super._render(force, options);
}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix for super optional args, downcase / upcase string methods ruby2js/ruby2js
1 participant
@esb