Skip to content

Allow $ in identificators for SQL #164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jasir opened this issue Feb 25, 2014 · 5 comments · Fixed by #173
Closed

Allow $ in identificators for SQL #164

jasir opened this issue Feb 25, 2014 · 5 comments · Fixed by #173
Assignees
@korny
Labels
Bug Scanners
Milestone
1.1.1

Comments

@jasir
Copy link

jasir commented Feb 25, 2014

In #90 there is a feature for full PL/SQL support.
We would like to address at least small bug.
In this query

   select value/1000 from  v$sesstat se,v$statname sn where se.STATISTIC# = sn.STATISTIC# and  sn.name =  'CPU used by this session' and se.SID=ss.SID

You can se v$abc identificators. They are valid, but they are marked as error by coderay. Is there anything we can do with this?
@korny
Copy link
Member

korny commented Feb 28, 2014

Do you know whether $ is allowed in all SQL dialects?

@korny korny added Bug labels Feb 28, 2014
@korny korny added this to the 1.1.1 milestone Feb 28, 2014
@korny korny self-assigned this Feb 28, 2014
@jasir
Copy link
Author

jasir commented Mar 4, 2014

It is allowed in postgreSQL and mySQL, just tried to create table with such identificators.

@korny
Copy link
Member

korny commented Mar 4, 2014

Thanks! Can you share the code here? I would add it as a test case…

@benbasson benbasson mentioned this issue Jun 12, 2014
Merged
@benbasson
Copy link
Contributor

@korny if I add tests for this will you consider merging the PR? Where would I go about adding tests?

korny added a commit that referenced this issue Feb 13, 2016
@korny
add changelog for #164
3e4bb6a
@korny
Copy link
Member

korny commented Feb 13, 2016

I added a test case in https://github.com/rubychan/coderay-scanner-tests/blob/master/sql/dollar-signs.in.sql.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@korny korny

Labels
Bug Scanners
Projects
None yet
Milestone
1.1.1
Development

Successfully merging a pull request may close this issue.

Allow $ in SQL identifiers benbasson/coderay
3 participants
@jasir @korny @benbasson