Skip to content

Move test suite to GitHub #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
nathany opened this issue Oct 27, 2012 · 5 comments
Closed

Move test suite to GitHub #43

nathany opened this issue Oct 27, 2012 · 5 comments
Assignees
Labels
Milestone

Comments

@nathany
Copy link
Contributor

nathany commented Oct 27, 2012

We need a coderay-scanner-tests repo to get started.

@ghost ghost assigned korny Oct 27, 2012
@nathany
Copy link
Contributor Author

nathany commented Oct 27, 2012

You might consider a GitHub organization for coderay, coderay-scanner-tests and the coderay web site. It would make it easier to manage commit access to the repos.

@nathany
Copy link
Contributor Author

nathany commented Oct 27, 2012

@korny I put a repo over here https://github.com/coderay/coderay-scanner-tests, but feel free to "Transfer" it into your @rubychan organization if you prefer.

@nathany
Copy link
Contributor Author

nathany commented Oct 28, 2012

So we need a LICENSE file for each folder in the example code? That's probably going to be difficult to track down now. :-(

@nathany
Copy link
Contributor Author

nathany commented Oct 28, 2012

We could probably use Git Submodules to have the tests in a separate repo, while making it easy to (optionally) fetch them.

@korny
Copy link
Member

korny commented Oct 28, 2012

Problem is branches/versions.

Yeah, actually I didn't have a problem with new scanners, since the tests are just ignored if no scanner is found. But if you fix anything, and change the expected output, you can't get master and the fix-branch to pass on the same repo revision :(

Decision was to keep it simple, just use one master branch instead of Submodules.

Again, from the chat:

Okay, so let's try this :) We use a normal git clone/git co instead of svn up. New scanner tests can always be added, but need to be skipped if the scanner is not found. Fixes should also be added, and we accept that this can cause master to fail.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants