Don't bind the current shell when create the new-instance Window

rogerwang · rogerwang · commit 008d9818815e · 2013-08-07T21:36:50.000+08:00
Fix nwjs#948
diff --git a/src/api/window/window.js b/src/api/window/window.js
@@ -56,6 +56,7 @@ exports.Window = {
 
     // Create new shell and get it's routing id.
     var routing_id = nw.createShell(url, options);
-    return new global.Window(routing_id);
+
+    return new global.Window(routing_id, options['new-instance']);
   }
 };
diff --git a/src/api/window_bindings.js b/src/api/window_bindings.js
@@ -1,4 +1,4 @@
-function Window(routing_id) {
+function Window(routing_id, nobind) {
   // Get and set id.
   var id = global.__nwObjectsRegistry.allocateId();
   Object.defineProperty(this, 'id', {
@@ -15,7 +15,8 @@ function Window(routing_id) {
 
   // Tell Shell I'm the js delegate of it.
   native function BindToShell();
-  BindToShell(this.routing_id, this.id);
+  if (!nobind)
+    BindToShell(this.routing_id, this.id);
 }
 
 // Window will inherit EventEmitter in "third_party/node/src/node.js", do

Original file line number	Diff line number	Diff line change
`@@ -56,6 +56,7 @@ exports.Window = {`
`56`	`56`
`57`	`57`	`// Create new shell and get it's routing id.`
`58`	`58`	`var routing_id = nw.createShell(url, options);`
`59`		`- return new global.Window(routing_id);`
	`59`	`+`
	`60`	`+ return new global.Window(routing_id, options['new-instance']);`
`60`	`61`	`}`
`61`	`62`	`};`