window.open should show the window by default even though the show option from package.json. Fix nwjs#491.

zhchbin · zhchbin · commit 150ccb3e1c9d · 2013-03-02T13:38:29.000+08:00
diff --git a/src/nw_shell.cc b/src/nw_shell.cc
@@ -403,6 +403,8 @@ void Shell::WebContentsCreated(WebContents* source_contents,
     manifest->SetInteger(switches::kmX, features.x);
   if (features.ySet)
     manifest->SetInteger(switches::kmY, features.y);
+  // window.open should show the window by default.
+  manifest->SetBoolean(switches::kmShow, true);
 
   new Shell(new_contents, manifest.get());
 }

Original file line number	Diff line number	Diff line change
`@@ -403,6 +403,8 @@ void Shell::WebContentsCreated(WebContents* source_contents,`
`403`	`403`	`manifest->SetInteger(switches::kmX, features.x);`
`404`	`404`	`if (features.ySet)`
`405`	`405`	`manifest->SetInteger(switches::kmY, features.y);`
	`406`	`+ // window.open should show the window by default.`
	`407`	`+ manifest->SetBoolean(switches::kmShow, true);`
`406`	`408`
`407`	`409`	`new Shell(new_contents, manifest.get());`
`408`	`410`	`}`