tried to move crash dump initialization earlier

rogerwang · rogerwang · commit 3be78bc54b86 · 2013-10-05T19:35:52.000+08:00
diff --git a/src/shell_browser_main_parts.cc b/src/shell_browser_main_parts.cc
@@ -30,6 +30,7 @@
 #include "chrome/common/chrome_switches.h"
 #include "content/nw/src/api/app/app.h"
 #include "content/nw/src/api/dispatcher_host.h"
+#include "content/nw/src/breakpad_linux.h"
 #include "content/nw/src/browser/printing/print_job_manager.h"
 #include "content/nw/src/browser/shell_devtools_delegate.h"
 #include "content/nw/src/common/shell_switches.h"
@@ -160,6 +161,7 @@ int ShellBrowserMainParts::PreCreateThreads() {
 
 void ShellBrowserMainParts::Init() {
   package_.reset(new nw::Package());
+  CommandLine& command_line = *CommandLine::ForCurrentProcess();
 
   browser_context_.reset(new ShellBrowserContext(false, package()));
   off_the_record_browser_context_.reset(
@@ -181,7 +183,7 @@ void ShellBrowserMainParts::Init() {
   int port = 0;
   // See if the user specified a port on the command line (useful for
   // automation). If not, use an ephemeral port by specifying 0.
-  CommandLine& command_line = *CommandLine::ForCurrentProcess();
+
   if (command_line.HasSwitch(switches::kRemoteDebuggingPort)) {
     int temp_port;
     std::string port_str =
diff --git a/src/shell_main_delegate.cc b/src/shell_main_delegate.cc
@@ -142,6 +142,11 @@ void ShellMainDelegate::PreSandboxStartup() {
   InitializeResourceBundle();
 
   CommandLine* command_line = CommandLine::ForCurrentProcess();
+  std::string process_type =
+      command_line->GetSwitchValueASCII(switches::kProcessType);
+
+  if (process_type != switches::kZygoteProcess)
+    InitCrashReporter();
 
   // Just prevent sandbox.
   command_line->AppendSwitch(switches::kNoSandbox);
@@ -159,11 +164,6 @@ void ShellMainDelegate::PreSandboxStartup() {
   command_line->AppendSwitch(switches::kAllowFileAccessFromFiles);
   command_line->AppendSwitch(switches::kEnableExperimentalWebPlatformFeatures);
   command_line->AppendSwitch(switches::kEnableCssShaders);
-  std::string process_type =
-      command_line->GetSwitchValueASCII(switches::kProcessType);
-
-  if (process_type != switches::kZygoteProcess)
-    InitCrashReporter();
 }
 
 int ShellMainDelegate::RunProcess(
