Skip to content

Commit 442a749

Browse files
committed
[test] fix race condition in issue4521-notification-perm
1 parent e3538bb commit 442a749

File tree

2 files changed

+3
-2
lines changed

2 files changed

+3
-2
lines changed

DEPS

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -99,7 +99,7 @@ vars = {
9999
# as an expression.
100100
'cros_download_vm': '"{cros_board}" == "amd64-generic"',
101101

102-
'nw_src_revision': '7f78a8f1ed6f7827731479a9c44e3fd58f43944c',
102+
'nw_src_revision': 'ea660eadf08a64e21107cc4059d7e0c6a3e3a8f3',
103103
'nw_v8_revision': '625978eb34d6400b58cac9034057d74467d1599b',
104104
'nw_node_revision': 'ccd5b0187286f938cef808acb5bd0832ad5026a0',
105105
# ANGLE's deps are relative to the angle_root variable.

test/sanity/issue4521-notification-perm/test.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@
1111

1212
def test_perm(driver, click_id, find_id, should_close_window=False, expected='granted'):
1313
driver.find_element_by_id(click_id).click()
14-
result = driver.find_element_by_id(find_id).get_attribute('innerHTML')
14+
result = wait_for_element_id(driver, find_id)
1515
print result
1616
assert(expected in result)
1717
if should_close_window == True:
@@ -23,6 +23,7 @@ def test_perm(driver, click_id, find_id, should_close_window=False, expected='gr
2323

2424
chrome_options = Options()
2525
chrome_options.add_argument("nwapp=" + os.path.dirname(os.path.abspath(__file__)))
26+
chrome_options.add_argument("skip-reopen-app-devtools")
2627

2728
testdir = os.path.dirname(os.path.abspath(__file__))
2829
os.chdir(testdir)

0 commit comments

Comments
 (0)