delete dispatcher objs correctly

rogerwang · rogerwang · commit 76261c1ec388 · 2014-02-21T13:44:59.000+08:00
Fix crash on quit after reloadDev
diff --git a/src/api/dispatcher_host.cc b/src/api/dispatcher_host.cc
@@ -59,9 +59,8 @@ DispatcherHost::~DispatcherHost() {
   g_dispatcher_host_map.erase(render_view_host());
   std::set<int>::iterator it;
   for (it = objects_.begin(); it != objects_.end(); it++) {
-    if (Base* obj = GetApiObject(*it)) {
-      delete obj;
-    }
+    if (objects_registry_.Lookup(*it))
+      objects_registry_.Remove(*it);
   }
 }
 

Original file line number	Diff line number	Diff line change
`@@ -59,9 +59,8 @@ DispatcherHost::~DispatcherHost() {`
`59`	`59`	`g_dispatcher_host_map.erase(render_view_host());`
`60`	`60`	`std::set<int>::iterator it;`
`61`	`61`	`for (it = objects_.begin(); it != objects_.end(); it++) {`
`62`		`- if (Base* obj = GetApiObject(*it)) {`
`63`		`- delete obj;`
`64`		`- }`
	`62`	`+ if (objects_registry_.Lookup(*it))`
	`63`	`+ objects_registry_.Remove(*it);`
`65`	`64`	`}`
`66`	`65`	`}`
`67`	`66`