Fix crash on exit: PageClickTracker is deleted twice

rogerwang · rogerwang · commit cc23d509faaf · 2013-10-24T10:56:31.000+08:00
diff --git a/src/renderer/shell_content_renderer_client.cc b/src/renderer/shell_content_renderer_client.cc
@@ -185,7 +185,11 @@ void ShellContentRendererClient::RenderViewCreated(RenderView* render_view) {
 #endif
 
   nw::AutofillAgent* autofill_agent = new nw::AutofillAgent(render_view);
-  page_click_tracker_.reset(new autofill::PageClickTracker(render_view, autofill_agent));
+
+  // The PageClickTracker is a RenderViewObserver, and hence will be freed when
+  // the RenderView is destroyed.
+  new autofill::PageClickTracker(render_view, autofill_agent);
+
   // PasswordAutofillAgent* password_autofill_agent =
   //     new PasswordAutofillAgent(render_view);
   // new AutofillAgent(render_view, password_autofill_agent);
diff --git a/src/renderer/shell_content_renderer_client.h b/src/renderer/shell_content_renderer_client.h
@@ -54,7 +54,6 @@ class ShellContentRendererClient : public ContentRendererClient {
  private:
   scoped_ptr<ShellRenderProcessObserver> shell_observer_;
   scoped_ptr<api::WindowBindings> window_bindings_;
-  scoped_ptr<autofill::PageClickTracker> page_click_tracker_;
 
   void InstallNodeSymbols(WebKit::WebFrame* frame,
                           v8::Handle<v8::Context> context, const GURL& url);
