Fix nwjs#5062: provide process.versions['nw-flavor'] and documentation

rogerwang · rogerwang · commit e330c3d463aa · 2018-01-28T19:46:24.000+08:00
diff --git a/docs/For Users/Advanced/Build Flavors.md b/docs/For Users/Advanced/Build Flavors.md
@@ -6,7 +6,8 @@
 NW.js supports various build flavors for reducing the application size. Currently NW.js supports following build flavors:
 
 * SDK flavor: has builtin support for DevTools and NaCl plugins. SDK flavor has the same capabilities as the builds before 0.13.0
-* NaCL flavor: supports Native Client (NaCl) plugins, but has no builtin DevTools.
 * Normal flavor: is a minimum build without DevTools and NaCl plugin support.
 
+In your code, you can use `process.versions['nw-flavor']` to see in which flavor your application is running.
+
 See [Build Flavors section in Building NW.js](../../For Developers/Building NW.js.md#build-flavors) for how to build them from source code.
diff --git a/docs/References/Changes to Node.md b/docs/References/Changes to Node.md
@@ -11,6 +11,7 @@ A couple of new fields is added to the global `process` object:
 
 * `process.versions['nw']` is set with NW.js's version.
 * `process.versions['chromium']` is set with the chromium version which NW.js is based on.
+* `process.versions['nw-flavor']` is set to 'sdk' when the binary is SDK build, or 'normal' when the binary is normal build.
 * `process.mainModule` is set for the start page (such as `index.html`) as specified in the manifest's [`main`](Manifest Format.md#main) field. However, when the [`node-main`](Manifest Format.md#node-main) field is also specified in the manifest, `process.mainModule` points to the file specified in the `node-main` field.
 
 ## require
diff --git a/src/renderer/nw_extensions_renderer_hooks.cc b/src/renderer/nw_extensions_renderer_hooks.cc
@@ -241,11 +241,17 @@ void ContextCreationHook(blink::WebLocalFrame* frame, ScriptContext* context) {
 
       g_start_nw_instance_fn(argc, argv, dom_context);
       {
+#if defined(NWJS_SDK)
+        std::string flavor = "sdk";
+#else
+        std::string flavor = "normal";
+#endif
         v8::Local<v8::Script> script =
           v8::Script::Compile(v8::String::NewFromUtf8(isolate,
                                                       (std::string("process.versions['nw'] = '" NW_VERSION_STRING "';") +
                                                        "process.versions['node-webkit'] = '" NW_VERSION_STRING "';"
                                                        "process.versions['nw-commit-id'] = '" NW_COMMIT_HASH "';"
+                                                       "process.versions['nw-flavor'] = '" + flavor + "';"
                                                        "process.versions['chromium'] = '" + GetChromiumVersion() + "';").c_str()
          ));
         script->Run();
