Skip to content

Commit e9f3ee9

Browse files
committed
fix the stall of save_devtools_setting
1 parent 912d92e commit e9f3ee9

File tree

1 file changed

+4
-7
lines changed
  • tests/automatic_tests/save_devtools_settings

1 file changed

+4
-7
lines changed

tests/automatic_tests/save_devtools_settings/index.html

Lines changed: 4 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,6 @@
3131
else {
3232
// open settitng
3333
devtools.WebInspector.SettingsController.prototype.showSettingsScreen();
34-
3534
// save original settings
3635
// general
3736
devtools.WebInspector.settingsController._settingsScreen._tabbedPane._tabs[0]._tabbedPane.selectTab('general', true);
@@ -55,7 +54,7 @@
5554
result.push(devtools.document.getElementsByName('Enable source maps')[0].checked);
5655
// 0~3
5756
result.push(devtools.document.getElementsByClassName('toplevel')[0].childNodes[1].selectedIndex);
58-
result.push(devtools.document.getElementsByName('Use CodeMirror editor')[0].checked);
57+
result.push(devtools.document.getElementsByName('Show whitespace characters')[0].checked);
5958
result.push(devtools.document.getElementsByName("Show objects' hidden properties")[0].checked);
6059
result.push(devtools.document.getElementsByName('Limit number of captured JS stack frames')[0].checked);
6160
result.push(devtools.document.getElementsByClassName('numeric')[0].value);
@@ -66,7 +65,6 @@
6665
result.push(devtools.document.getElementsByName('Enable Ctrl + 1-9 shortcut to switch panels')[0].checked);
6766
else
6867
result.push(devtools.document.getElementsByName('Enable Cmd + 1-9 shortcut to switch panels')[0].checked);
69-
7068
// overrides
7169
devtools.WebInspector.settingsController._settingsScreen._tabbedPane._tabs[0]._tabbedPane.selectTab("overrides", true);
7270

@@ -87,11 +85,10 @@
8785
result.push(devtools.document.getElementById('device-orientation-override-alpha').value);
8886
result.push(devtools.document.getElementById('device-orientation-override-beta').value);
8987
result.push(devtools.document.getElementById('device-orientation-override-gamma').value);
90-
result.push(devtools.document.getElementsByName('Emulate touch events')[0].checked);
88+
result.push(devtools.document.getElementsByClassName('help-block')[4].childNodes[0].childNodes[0].childNodes[0].checked);
9189
result.push(devtools.document.getElementsByClassName('help-block')[5].childNodes[0].childNodes[0].childNodes[0].checked);
9290
// 0~8
9391
result.push(devtools.document.getElementsByClassName('help-block')[5].childNodes[0].childNodes[1].selectedIndex);
94-
9592
if (action == '1') {
9693
var i = 0;
9794
// change original settings
@@ -115,7 +112,7 @@
115112
if (!result[i - 1])
116113
// 0~3
117114
devtools.document.getElementsByClassName('toplevel')[0].childNodes[1].selectedIndex = (result[i++] + 1) % 4;
118-
devtools.document.getElementsByName('Use CodeMirror editor')[0].click(); i++;
115+
devtools.document.getElementsByName('Show whitespace characters')[0].click(); i++;
119116
devtools.document.getElementsByName("Show objects' hidden properties")[0].click(); i++;
120117
devtools.document.getElementsByName('Limit number of captured JS stack frames')[0].click(); i++;
121118
if (!result[i - 1])
@@ -153,7 +150,7 @@
153150
devtools.document.getElementById('device-orientation-override-beta').value = (result[i++] + 1) % 10;
154151
devtools.document.getElementById('device-orientation-override-gamma').value = (result[i++] + 1) % 10;
155152
}
156-
devtools.document.getElementsByName('Emulate touch events')[0].click(); i++;
153+
devtools.document.getElementsByClassName('help-block')[4].childNodes[0].childNodes[0].childNodes[0].click(); i++;
157154
devtools.document.getElementsByClassName('help-block')[5].childNodes[0].childNodes[0].childNodes[0].click(); i++;
158155
if (!result[i - 1])
159156
// 0~8

0 commit comments

Comments
 (0)