Only pristine executables for default gems #8130
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Uhh, default gems are complex. |
a2e89bc to
1cfc1d6
Compare
|
They are! 😅 |
simi
approved these changes
Oct 10, 2024
4 tasks
deivid-rodriguez
pushed a commit
that referenced
this pull request
Oct 16, 2024
…-default-gem-specifications Only pristine executables for default gems (cherry picked from commit 95b5b71)
This was referenced Jun 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the end-user or developer problem that led to this PR?
In #8118, we allowed
gem pristineto reset default gems. That essentially means resetting their installed.gemspecfiles, and their binstubs, because their actual code "belongs to Ruby installation".However, we can't really reset
.gemspecfiles either, because they include some tweaks from ruby-core for default gem activation to work that cannot be reset from a remote.gemfile.What is your fix for the problem, implemented in this PR?
Limit
gem pristineto executables when running for a default gem.Make sure the following tasks are checked