Skip to content

Commit 08c20f4

Browse files
committed
Adjust patches for older release
1 parent 9e9e4cf commit 08c20f4

5 files changed

+9
-78
lines changed

build-libv8

Lines changed: 1 addition & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -14,24 +14,7 @@ echo "parallel job count: ${NJOBS}"
1414

1515
cd "src/node-${version}"
1616

17-
if which python3 >/dev/null 2>&1; then
18-
PYTHON="${PYTHON:-python3}"
19-
else
20-
PYTHON="${PYTHON:-python2}"
21-
fi
22-
23-
case "${platform}" in
24-
SunOS)
25-
export CC="${CC:-/opt/local/gcc7/bin/gcc}"
26-
export CXX="${CXX:-/opt/local/gcc7/bin/g++}"
27-
;;
28-
*)
29-
if cc --version | grep 4.9 >/dev/null; then
30-
export CC="${CC:-clang}"
31-
export CXX="${CXX:-clang++}"
32-
fi
33-
;;
34-
esac
17+
PYTHON="${PYTHON:-python2}"
3518

3619
"${PYTHON}" configure --openssl-no-asm --without-npm --shared --with-intl=small-icu
3720
make BUILDTYPE=Release config.gypi

extract-node

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -21,16 +21,4 @@ esac
2121
cd "src/node-${version}"
2222

2323
patch -p1 < ../../gyp-libv8_monolith.patch
24-
patch -p1 < ../../py2-icutrim.patch
2524
patch -p1 < ../../py2-genv8constants.patch
26-
27-
# TODO: the following still fails on py3 so the above one forcing py2 is needed
28-
# patch -p1 < ../../py3-genv8constants.patch
29-
#
30-
# This is the error:
31-
#
32-
# Traceback (most recent call last):
33-
# File "tools/genv8constants.py", line 99, in <module>
34-
# curr_val += int('0x%s' % octetstr, 16) << (curr_octet * 8)
35-
# ValueError: invalid literal for int() with base 16: "0xb'04 '"
36-
# node_dtrace_ustack.target.mk:13: recipe for target '/usbkey/user_home/vagrant/ruby-libv8-node/src/node-14.14.0/out/Release/obj/gen/v8constants.h' failed

gyp-libv8_monolith.patch

Lines changed: 8 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -3,35 +3,29 @@
33
@@ -1467,6 +1467,16 @@
44
}],
55
],
6-
}, # node_mksnapshot
6+
}, # cctest
77
+ {
88
+ 'target_name': 'libv8_monolith',
99
+ 'type': 'none',
1010
+ 'includes': [
1111
+ 'node.gypi'
1212
+ ],
1313
+ #'dependencies': [
14-
+ # 'tools/v8_gypfiles/v8.gyp:v8_monolith',
14+
+ # 'deps/v8/gypfiles/v8.gyp:v8_monolith',
1515
+ #],
1616
+ },
1717
], # end targets
1818

1919
'conditions': [
20-
--- a/tools/v8_gypfiles/v8.gyp 2020-11-04 16:34:06.000000000 +0100
21-
+++ b/tools/v8_gypfiles/v8.gyp 2020-11-04 16:34:10.000000000 +0100
22-
@@ -1726,5 +1726,21 @@
23-
'<(V8_ROOT)/third_party/zlib/google/compression_utils_portable.h',
24-
],
25-
}, # v8_zlib
20+
--- a/deps/v8/gypfiles/v8.gyp 2020-11-04 16:34:06.000000000 +0100
21+
+++ b/deps/v8/gypfiles/v8.gyp 2020-11-04 16:34:10.000000000 +0100
22+
@@ -1726,5 +1726,15 @@
23+
{
24+
'includes': [ 'v8_external_snapshot.gypi' ],
25+
}, # v8_external_snapshot
2626
+ {
2727
+ 'target_name': 'v8_monolith',
2828
+ 'type': 'static_library',
29-
+ 'sources': [
30-
+ '<!@pymod_do_main(GN-scraper "<(V8_ROOT)/BUILD.gn" "\\"v8.*?sources = ")',
31-
+ '<!@pymod_do_main(GN-scraper "<(V8_ROOT)/BUILD.gn" "\\"v8_libbase.*?sources = ")',
32-
+ '<!@pymod_do_main(GN-scraper "<(V8_ROOT)/BUILD.gn" "\\"v8_libplatform.*?sources = ")',
33-
+ '<!@pymod_do_main(GN-scraper "<(V8_ROOT)/BUILD.gn" "\\"v8_libsampler.*?sources = ")',
34-
+ ],
3529
+ 'dependencies': [
3630
+ 'v8',
3731
+ 'v8_libbase',

py2-icutrim.patch

Lines changed: 0 additions & 14 deletions
This file was deleted.

py3-genv8constants.patch

Lines changed: 0 additions & 20 deletions
This file was deleted.

0 commit comments

Comments
 (0)