Skip to content

Commit 3cf109f

Browse files
committed
Define gem files explicitly
1 parent cf6b17b commit 3cf109f

File tree

2 files changed

+5
-6
lines changed

2 files changed

+5
-6
lines changed

Dockerfile

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -19,11 +19,6 @@ RUN ./build-monolith ${NODE_VERSION}
1919
COPY inject-libv8 /code/
2020
RUN ./inject-libv8 ${NODE_VERSION}
2121

22-
# without this `COPY .git`, we get the following error:
23-
# fatal: not a git repository (or any of the parent directories): .git
24-
# but with it we need the full gem just to compile the extension because
25-
# of gemspec's `git --ls-files`
26-
# COPY .git /code/.git
2722
COPY Gemfile libv8-node.gemspec /code/
2823
COPY lib/libv8/node/version.rb /code/lib/libv8/node/version.rb
2924
RUN bundle install

libv8-node.gemspec

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,11 @@ Gem::Specification.new do |s|
1212
s.description = "Node.JS's V8 JavaScript engine for multiplatform goodness"
1313
s.license = 'MIT'
1414

15-
s.files = `git ls-files`.split("\n")
15+
s.files = Dir['ext/**/*.rb'] +
16+
Dir['lib/**/*.rb'] +
17+
Dir['libexec/*'] +
18+
Dir['patch/*'] +
19+
['LICENSE', 'README.md', 'CHANGELOG.md']
1620

1721
s.extensions = ['ext/libv8-node/extconf.rb']
1822
s.require_paths = ['lib', 'ext']

0 commit comments

Comments
 (0)