diff --git a/libexec/extract-node b/libexec/extract-node index 73e6073..395abb9 100755 --- a/libexec/extract-node +++ b/libexec/extract-node @@ -32,6 +32,7 @@ cd "${src}/node-v${version}" #patch -p1 < "${top}"/patch/gyp-libv8_monolith.patch #patch -p1 < "${top}"/patch/py2-icutrim.patch #patch -p1 < "${top}"/patch/py2-genv8constants.patch +patch -p1 < "${top}"/patch/v8-disable-pkey.patch # TODO: the following still fails on py3 so the above one forcing py2 is needed # patch -p1 < ../../py3-genv8constants.patch diff --git a/patch/v8-disable-pkey.patch b/patch/v8-disable-pkey.patch new file mode 100644 index 0000000..f3a3718 --- /dev/null +++ b/patch/v8-disable-pkey.patch @@ -0,0 +1,17 @@ +diff --git a/deps/v8/src/base/build_config.h b/deps/v8/src/base/build_config.h +index 9ed4c8f102..dfca698506 100644 +--- a/deps/v8/src/base/build_config.h ++++ b/deps/v8/src/base/build_config.h +@@ -35,11 +35,8 @@ + #define V8_HAS_PTHREAD_JIT_WRITE_PROTECT 0 + #endif + +-#if defined(V8_OS_LINUX) && defined(V8_HOST_ARCH_X64) +-#define V8_HAS_PKU_JIT_WRITE_PROTECT 1 +-#else ++// disabled, see https://issues.chromium.org/issues/360909072 + #define V8_HAS_PKU_JIT_WRITE_PROTECT 0 +-#endif + + #if defined(V8_TARGET_ARCH_IA32) || defined(V8_TARGET_ARCH_X64) + #define V8_TARGET_ARCH_STORES_RETURN_ADDRESS_ON_STACK true