diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index f194861..4e3dee4 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -1,5 +1,6 @@ name: Build on: + - pull_request - push jobs: diff --git a/test/gtest/CMakeLists.txt b/test/gtest/CMakeLists.txt index 915947c..289bd41 100644 --- a/test/gtest/CMakeLists.txt +++ b/test/gtest/CMakeLists.txt @@ -1,8 +1,8 @@ cmake_minimum_required(VERSION 3.14) project(gtest) -# GoogleTest requires at least C++14 -set(CMAKE_CXX_STANDARD 14) +# V8 requires at least C++17 +set(CMAKE_CXX_STANDARD 17) include(FetchContent) FetchContent_Declare( diff --git a/test/gtest/Framework.h b/test/gtest/Framework.h index ed54c59..59bacfe 100644 --- a/test/gtest/Framework.h +++ b/test/gtest/Framework.h @@ -16,7 +16,7 @@ struct Framework { main(); v8::V8::Dispose(); - v8::V8::ShutdownPlatform(); + v8::V8::DisposePlatform(); } inline static void runWithIsolateRaw(iso_main main) { @@ -50,4 +50,4 @@ struct Framework { main(ctx); }); } -}; \ No newline at end of file +};