From cd76dd9489c3a24e42d3df91be9dbc7f2802d5f0 Mon Sep 17 00:00:00 2001 From: Ben Noordhuis Date: Fri, 24 Jan 2025 23:31:53 +0100 Subject: [PATCH 1/4] Update to node 22.13.1 --- lib/libv8/node/version.rb | 4 ++-- sums/v22.13.1.sum | 1 + 2 files changed, 3 insertions(+), 2 deletions(-) create mode 100644 sums/v22.13.1.sum diff --git a/lib/libv8/node/version.rb b/lib/libv8/node/version.rb index 80a093f..bebed4a 100644 --- a/lib/libv8/node/version.rb +++ b/lib/libv8/node/version.rb @@ -4,7 +4,7 @@ module Libv8 end module Libv8::Node - VERSION = '22.9.0.0' - NODE_VERSION = '22.9.0' + VERSION = '22.13.1.0' + NODE_VERSION = '22.13.1' LIBV8_VERSION = '12.4.254.21' # from src/node-.../deps/v8/include/v8-version.h end diff --git a/sums/v22.13.1.sum b/sums/v22.13.1.sum new file mode 100644 index 0000000..60e9fbc --- /dev/null +++ b/sums/v22.13.1.sum @@ -0,0 +1 @@ +e7d5b1e84e7f3c3cebda81e2b138469eef41ba4ecf16a87fd15fc3f7afa3f701 From a94279756891c51b174c14b8051f8aeef4959ffd Mon Sep 17 00:00:00 2001 From: Ben Noordhuis Date: Fri, 24 Jan 2025 23:42:13 +0100 Subject: [PATCH 2/4] fix! remove obsolete patch --- libexec/extract-node | 1 - patch/v8-debug-flags-hang.patch | 26 -------------------------- 2 files changed, 27 deletions(-) delete mode 100644 patch/v8-debug-flags-hang.patch diff --git a/libexec/extract-node b/libexec/extract-node index 2fed7c6..61b5b2a 100755 --- a/libexec/extract-node +++ b/libexec/extract-node @@ -32,4 +32,3 @@ cd "${src}/node-v${version}" patch -p1 < "${top}"/patch/v8-std-is-trivially-destructible.patch patch -p1 < "${top}"/patch/v8-disable-madv-dontfork.patch patch -p1 < "${top}"/patch/v8-disable-pkey.patch -patch -p1 < "${top}"/patch/v8-debug-flags-hang.patch diff --git a/patch/v8-debug-flags-hang.patch b/patch/v8-debug-flags-hang.patch deleted file mode 100644 index ddfb218..0000000 --- a/patch/v8-debug-flags-hang.patch +++ /dev/null @@ -1,26 +0,0 @@ -diff --git a/deps/v8/src/flags/flags-impl.h b/deps/v8/src/flags/flags-impl.h -index d2d440c026..111b9b5b9c 100644 ---- a/deps/v8/src/flags/flags-impl.h -+++ b/deps/v8/src/flags/flags-impl.h -@@ -5,6 +5,8 @@ - #ifndef V8_FLAGS_FLAGS_IMPL_H_ - #define V8_FLAGS_FLAGS_IMPL_H_ - -+#include -+ - #include "src/base/macros.h" - #include "src/base/optional.h" - #include "src/base/vector.h" -@@ -91,9 +93,12 @@ struct Flag { - #ifdef DEBUG - bool ImpliedBy(const void* ptr) const { - const Flag* current = this->implied_by_ptr_; -+ std::unordered_set visited_flags; - while (current != nullptr) { -+ visited_flags.insert(current); - if (current->PointsTo(ptr)) return true; - current = current->implied_by_ptr_; -+ if (visited_flags.contains(current)) break; - } - return false; - } From 31062f53a59898f32e5da560489dced2d9632b97 Mon Sep 17 00:00:00 2001 From: Ben Noordhuis Date: Mon, 27 Jan 2025 08:34:31 +0100 Subject: [PATCH 3/4] try? macos-12 -> macos-14 --- .github/workflows/build.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index 661ceb2..0a22159 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -82,7 +82,7 @@ jobs: name: Build (darwin) outputs: GEM_VERSION: ${{ steps.set-metadata.outputs.GEM_VERSION }} - runs-on: macos-12 + runs-on: macos-14 env: TARGET_PLATFORM: ${{ matrix.platform }}-darwin RUBY_TARGET_PLATFORM: ${{ matrix.platform }}-darwin @@ -352,7 +352,7 @@ jobs: # arm64 name: Test (darwin) needs: build-darwin - runs-on: macos-12 + runs-on: macos-14 steps: - name: Set metadata id: set-metadata From 119e08684189ba902422e1492e40ec6c0e32ad47 Mon Sep 17 00:00:00 2001 From: Ben Noordhuis Date: Mon, 27 Jan 2025 22:48:51 +0100 Subject: [PATCH 4/4] try? macos 14 -> 13 for x86_64 --- .github/workflows/build.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index 0a22159..06e8a15 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -82,7 +82,7 @@ jobs: name: Build (darwin) outputs: GEM_VERSION: ${{ steps.set-metadata.outputs.GEM_VERSION }} - runs-on: macos-14 + runs-on: macos-13 env: TARGET_PLATFORM: ${{ matrix.platform }}-darwin RUBY_TARGET_PLATFORM: ${{ matrix.platform }}-darwin @@ -352,7 +352,7 @@ jobs: # arm64 name: Test (darwin) needs: build-darwin - runs-on: macos-14 + runs-on: macos-13 steps: - name: Set metadata id: set-metadata