From b234a7155e187c41d82991a43380257c514ab1da Mon Sep 17 00:00:00 2001 From: Ben Noordhuis Date: Thu, 30 Jan 2025 22:38:33 +0100 Subject: [PATCH] Update to node 23.6.1 --- .github/workflows/build.yml | 16 ++++++++-------- lib/libv8/node/version.rb | 6 +++--- sums/v23.6.1.sum | 1 + test/gtest/CMakeLists.txt | 4 ++-- 4 files changed, 14 insertions(+), 13 deletions(-) create mode 100644 sums/v23.6.1.sum diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index 06e8a15..921d945 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -68,7 +68,7 @@ jobs: run: | bundle exec rake build - name: Upload gem - uses: actions/upload-artifact@v3 + uses: actions/upload-artifact@v4 with: name: gem-${{ steps.set-metadata.outputs.GEM_VERSION }}-ruby path: pkg @@ -135,12 +135,12 @@ jobs: run: | bundle exec rake binary - name: Upload V8 - uses: actions/upload-artifact@v3 + uses: actions/upload-artifact@v4 with: name: v8-${{ steps.set-metadata.outputs.LIBV8_VERSION }}-${{ steps.set-metadata.outputs.GEM_PLATFORM }} path: vendor - name: Upload gem - uses: actions/upload-artifact@v3 + uses: actions/upload-artifact@v4 with: name: gem-${{ steps.set-metadata.outputs.GEM_VERSION }}-${{ steps.set-metadata.outputs.GEM_PLATFORM }} path: pkg @@ -274,12 +274,12 @@ jobs: run: | docker exec -w "${PWD}" ${{ steps.container.outputs.id }} bundle exec rake binary[${{ steps.platform.outputs.ruby_target_platform }}] - name: Upload V8 - uses: actions/upload-artifact@v3 + uses: actions/upload-artifact@v4 with: name: v8-${{ steps.set-metadata.outputs.LIBV8_VERSION }}-${{ steps.platform.outputs.ruby_target_platform }} path: vendor - name: Upload gem - uses: actions/upload-artifact@v3 + uses: actions/upload-artifact@v4 with: name: gem-${{ steps.set-metadata.outputs.GEM_VERSION }}-${{ steps.platform.outputs.ruby_target_platform }} path: pkg @@ -327,7 +327,7 @@ jobs: ruby -e 'puts Gem.platforms.last.to_s' | tee gem_platform echo "::set-output name=GEM_PLATFORM::$(cat gem_platform)" - name: Download a single artifact - uses: actions/download-artifact@v3 + uses: actions/download-artifact@v4 with: name: gem-${{ needs.build-ruby.outputs.GEM_VERSION }}-ruby path: pkg @@ -360,7 +360,7 @@ jobs: ruby -e 'puts Gem.platforms.last.to_s.gsub(/-darwin-?\d+/, "-darwin")' | tee gem_platform echo "::set-output name=GEM_PLATFORM::$(cat gem_platform)" - name: Download a single artifact - uses: actions/download-artifact@v3 + uses: actions/download-artifact@v4 with: name: gem-${{ needs.build-darwin.outputs.GEM_VERSION }}-${{ steps.set-metadata.outputs.GEM_PLATFORM }} path: pkg @@ -440,7 +440,7 @@ jobs: docker exec -w "${PWD}" ${{ steps.container.outputs.id }} ruby -e 'puts Gem::Platform.local.tap { |p| RUBY_PLATFORM =~ /musl/ && p.version.nil? and p.instance_eval { @version = "musl" } }.to_s' | tee gem_platform echo "::set-output name=GEM_PLATFORM::$(cat gem_platform)" - name: Download a single artifact - uses: actions/download-artifact@v3 + uses: actions/download-artifact@v4 with: name: gem-${{ needs.build-linux.outputs.GEM_VERSION }}-${{ steps.set-metadata.outputs.GEM_PLATFORM }} path: pkg diff --git a/lib/libv8/node/version.rb b/lib/libv8/node/version.rb index bebed4a..de983fd 100644 --- a/lib/libv8/node/version.rb +++ b/lib/libv8/node/version.rb @@ -4,7 +4,7 @@ module Libv8 end module Libv8::Node - VERSION = '22.13.1.0' - NODE_VERSION = '22.13.1' - LIBV8_VERSION = '12.4.254.21' # from src/node-.../deps/v8/include/v8-version.h + VERSION = '23.6.1.0' + NODE_VERSION = '23.6.1' + LIBV8_VERSION = '12.9.202.28' # from src/node-.../deps/v8/include/v8-version.h end diff --git a/sums/v23.6.1.sum b/sums/v23.6.1.sum new file mode 100644 index 0000000..c61389c --- /dev/null +++ b/sums/v23.6.1.sum @@ -0,0 +1 @@ +35c0f7957085083071fcf01c7eaea953fba98f17afc4d7c189e3ef56925b453c diff --git a/test/gtest/CMakeLists.txt b/test/gtest/CMakeLists.txt index 289bd41..d2360c5 100644 --- a/test/gtest/CMakeLists.txt +++ b/test/gtest/CMakeLists.txt @@ -1,8 +1,8 @@ cmake_minimum_required(VERSION 3.14) project(gtest) -# V8 requires at least C++17 -set(CMAKE_CXX_STANDARD 17) +# V8 requires at least C++20 +set(CMAKE_CXX_STANDARD 20) include(FetchContent) FetchContent_Declare(