Skip to content

Commit cb41b00

Browse files
committed
cleanup TODOs, FIXMEs
1 parent 8e67efe commit cb41b00

File tree

5 files changed

+5
-6
lines changed

5 files changed

+5
-6
lines changed

bin/coderay

+3-2
Original file line numberDiff line numberDiff line change
@@ -155,8 +155,9 @@ when 'highlight', nil
155155
puts boom.message
156156
end
157157
# puts "I don't know this plugin: #{boom.message[/Could not load plugin (.*?): /, 1]}."
158-
rescue CodeRay::Scanners::Scanner::ScanError # FIXME: rescue Errno::EPIPE
159-
# this is sometimes raised by pagers; ignore [TODO: wtf?]
158+
rescue CodeRay::Scanners::Scanner::ScanError
159+
# this is sometimes raised by pagers; ignore
160+
# FIXME: rescue Errno::EPIPE
160161
ensure
161162
file.close if output_file
162163
end

lib/coderay.rb

-1
Original file line numberDiff line numberDiff line change
@@ -166,7 +166,6 @@ class << self
166166
#
167167
# See also demo/demo_simple.
168168
def scan code, lang, options = {}, &block
169-
# FIXME: return a proxy for direct-stream encoding
170169
TokensProxy.new code, lang, options, block
171170
end
172171

lib/coderay/encoders/html/numbering.rb

+1-1
Original file line numberDiff line numberDiff line change
@@ -75,7 +75,7 @@ def self.number! output, mode = :table, options = {}
7575
line_number = start
7676
output.gsub!(/^.*$\n?/) do |line|
7777
line_number_text = bolding.call line_number
78-
indent = ' ' * (max_width - line_number.to_s.size) # TODO: Optimize (10^x)
78+
indent = ' ' * (max_width - line_number.to_s.size)
7979
line_number += 1
8080
"<span class=\"line-numbers\">#{indent}#{line_number_text}</span>#{line}"
8181
end

lib/coderay/encoders/statistic.rb

-1
Original file line numberDiff line numberDiff line change
@@ -67,7 +67,6 @@ def text_token text, kind
6767
@type_stats['TOTAL'].count += 1
6868
end
6969

70-
# TODO Hierarchy handling
7170
def begin_group kind
7271
block_token ':begin_group', kind
7372
end

lib/coderay/token_kinds.rb

+1-1
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ module CodeRay
4444
:important => 'important', # CSS, Taskpaper
4545
:include => 'include', # C, Groovy, Java, Python, Sass
4646
:inline => 'inline', # nested code, eg. inline string evaluation; lots of scanners
47-
:inline_delimiter => 'inline-delimiter', # used instead of :inline > :delimiter FIXME: Why?
47+
:inline_delimiter => 'inline-delimiter', # used instead of :inline > :delimiter FIXME: Why use inline_delimiter?
4848
:instance_variable => 'instance-variable', # Ruby
4949
:integer => 'integer', # most scanners
5050
:key => 'key', # lots of scanners, used together with :value

0 commit comments

Comments
 (0)