Use runCommand to start sdkmanager and adjust the executable name for Windows (flutter#9962)

jason-simmons · web-flow · commit d1fa21166b38 · 2017-05-10T12:42:42.000-07:00
Fixes flutter#9954
diff --git a/packages/flutter_tools/lib/src/android/android_workflow.dart b/packages/flutter_tools/lib/src/android/android_workflow.dart
@@ -179,10 +179,13 @@ class AndroidWorkflow extends DoctorValidator implements Workflow {
           platform.environment['PATH'] + os.pathVarSeparator + fs.path.dirname(javaBinary);
     }
 
-    final Process process = await Process.start(
-      fs.path.join(androidSdk.directory, 'tools', 'bin', 'sdkmanager'),
-      <String>['--licenses'],
-      environment: sdkManagerEnv,
+    final String sdkManagerPath = fs.path.join(
+        androidSdk.directory, 'tools', 'bin',
+        platform.isWindows ? 'sdkmanager.bat' : 'sdkmanager',
+    );
+    final Process process = await runCommand(
+        <String>[sdkManagerPath, '--licenses'],
+        environment: sdkManagerEnv,
     );
     stdout.addStream(process.stdout);
     stderr.addStream(process.stderr);
