- Fix API

zsuraski · zsuraski · commit 49e45baf9bd3 · 2001-08-13T00:32:04.000Z
- Update NEWS
diff --git a/NEWS b/NEWS
@@ -1,6 +1,8 @@
 PHP 4.0                                                                    NEWS
 |||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
 ?? ??? 200?, Version 4.0.7-dev
+- Floating point numbers are better detected when converting from strings
+  (Zeev, Zend Engine)
 - Replaced php.ini-optimized with php.ini-recommended.  As the name implies,
   it's warmly recommended to use this file as the basis for your PHP
   configuration, rather than php.ini-dist.  (Zeev)
diff --git a/ext/standard/basic_functions.c b/ext/standard/basic_functions.c
@@ -1470,7 +1470,7 @@ PHP_FUNCTION(is_numeric)
 			break;
 
 		case IS_STRING:
-			result = is_numeric_string(Z_STRVAL_PP(arg), Z_STRLEN_PP(arg), NULL, NULL);
+			result = is_numeric_string(Z_STRVAL_PP(arg), Z_STRLEN_PP(arg), NULL, NULL, 0);
 			if (result == IS_LONG || result == IS_DOUBLE) {
 				RETURN_TRUE;
 			} else {
diff --git a/ext/standard/datetime.c b/ext/standard/datetime.c
@@ -690,7 +690,7 @@ PHP_FUNCTION(checkdate)
 	}
 
 	if((*year)->type == IS_STRING) {
-		res = is_numeric_string((*year)->value.str.val, (*year)->value.str.len, NULL, NULL);
+		res = is_numeric_string((*year)->value.str.val, (*year)->value.str.len, NULL, NULL, 0);
 		if(res!=IS_LONG && res !=IS_DOUBLE) {
 			RETURN_FALSE;	
 		}

Original file line number	Diff line number	Diff line change
`@@ -690,7 +690,7 @@ PHP_FUNCTION(checkdate)`
`690`	`690`	`}`
`691`	`691`
`692`	`692`	`if((*year)->type == IS_STRING) {`
`693`		`- res = is_numeric_string((year)->value.str.val, (year)->value.str.len, NULL, NULL);`
	`693`	`+ res = is_numeric_string((year)->value.str.val, (year)->value.str.len, NULL, NULL, 0);`
`694`	`694`	`if(res!=IS_LONG && res !=IS_DOUBLE) {`
`695`	`695`	`RETURN_FALSE;`
`696`	`696`	`}`