Skip to content

Refactor Extra Fields #140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
simonoff opened this issue Mar 9, 2014 · 3 comments
Closed

Refactor Extra Fields #140

simonoff opened this issue Mar 9, 2014 · 3 comments

Comments

@simonoff
Copy link
Member

simonoff commented Mar 9, 2014

Need to refactor extra fields collecting to support unknown fields what has different data in central directory and local entry.

@jstanley0
Copy link
Contributor

Hello @simonoff - I didn't see this issue before submitting #142, but that request is relevant to your concern here. (It's not a refactor or a full solution, but it resolves the data corruption issue when modifying existing archives where the central directory entry size doesn't match the local entry size.)

@simonoff
Copy link
Member Author

Hi @jstanley0 - Yes, it's bug in what local and central entries has a different sizes. I will working on getting extra for local and central directory as different entries and merge them and after using different methods to write local and central entries. Current code has a some things about it but if extra is unknown then it will be a corrupted archive.

@hainesr
Copy link
Member

hainesr commented May 29, 2021

Closing this because I think we do handle unknown extra fields now - and #459 fixed loading extra fields from both central directory and local headers.

@hainesr hainesr closed this as completed May 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants