drm/i915: print warning if vmi915_gem_fault error is not handled

mikuint · danvet · commit 4d0f817e7482 · 2012-10-04T10:33:42.000+02:00
Falling into default case in vmi915_gem_fault is a bug. Be more
verbose about it.

Signed-off-by: Mika Kuoppala &lt;mika.kuoppala@intel.com&gt;
Reviewed-by: Chris Wilson &lt;chris@chris-wilson.co.uk&gt;
Signed-off-by: Daniel Vetter &lt;daniel.vetter@ffwll.ch&gt;
diff --git a/drivers/gpu/drm/i915/i915_gem.c b/drivers/gpu/drm/i915/i915_gem.c
@@ -1409,6 +1409,7 @@ int i915_gem_fault(struct vm_area_struct *vma, struct vm_fault *vmf)
 	case -ENOMEM:
 		return VM_FAULT_OOM;
 	default:
+		WARN_ON_ONCE(ret);
 		return VM_FAULT_SIGBUS;
 	}
 }

Original file line number	Diff line number	Diff line change
`@@ -1409,6 +1409,7 @@ int i915_gem_fault(struct vm_area_struct vma, struct vm_fault vmf)`
`1409`	`1409`	`case -ENOMEM:`
`1410`	`1410`	`return VM_FAULT_OOM;`
`1411`	`1411`	`default:`
	`1412`	`+ WARN_ON_ONCE(ret);`
`1412`	`1413`	`return VM_FAULT_SIGBUS;`
`1413`	`1414`	`}`
`1414`	`1415`	`}`