mn10300: Add missing RCU idle APIs on idle loop

fweisbec · paulmck · commit 5b0753a90b7a · 2012-09-23T07:44:48.000-07:00
In the old times, the whole idle task was considered
as an RCU quiescent state. But as RCU became more and
more successful overtime, some RCU read side critical
section have been added even in the code of some
architectures idle tasks, for tracing for example.

So nowadays, rcu_idle_enter() and rcu_idle_exit() must
be called by the architecture to tell RCU about the part
in the idle loop that doesn't make use of rcu read side
critical sections, typically the part that puts the CPU
in low power mode.

This is necessary for RCU to find the quiescent states in
idle in order to complete grace periods.

Add this missing pair of calls in the mn10300's idle loop.

Reported-by: Paul E. McKenney &lt;paulmck@linux.vnet.ibm.com&gt;
Signed-off-by: Frederic Weisbecker &lt;fweisbec@gmail.com&gt;
Cc: David Howells &lt;dhowells@redhat.com&gt;
Cc: Koichi Yasutake &lt;yasutake.koichi@jp.panasonic.com&gt;
Cc: &lt;stable@vger.kernel.org&gt; # 3.3+
Signed-off-by: Paul E. McKenney &lt;paulmck@linux.vnet.ibm.com&gt;
Acked-by: David Howells &lt;dhowells@redhat.com&gt;
Reviewed-by: Josh Triplett &lt;josh@joshtriplett.org&gt;
diff --git a/arch/mn10300/kernel/process.c b/arch/mn10300/kernel/process.c
@@ -25,6 +25,7 @@
 #include <linux/err.h>
 #include <linux/fs.h>
 #include <linux/slab.h>
+#include <linux/rcupdate.h>
 #include <asm/uaccess.h>
 #include <asm/pgtable.h>
 #include <asm/io.h>
@@ -107,6 +108,7 @@ void cpu_idle(void)
 {
 	/* endless idle loop with no priority at all */
 	for (;;) {
+		rcu_idle_enter();
 		while (!need_resched()) {
 			void (*idle)(void);
 
@@ -121,6 +123,7 @@ void cpu_idle(void)
 			}
 			idle();
 		}
+		rcu_idle_exit();
 
 		schedule_preempt_disabled();
 	}

Original file line number	Diff line number	Diff line change
`@@ -25,6 +25,7 @@`
`25`	`25`	`#include <linux/err.h>`
`26`	`26`	`#include <linux/fs.h>`
`27`	`27`	`#include <linux/slab.h>`
	`28`	`+#include <linux/rcupdate.h>`
`28`	`29`	`#include <asm/uaccess.h>`
`29`	`30`	`#include <asm/pgtable.h>`
`30`	`31`	`#include <asm/io.h>`
`@@ -107,6 +108,7 @@ void cpu_idle(void)`
`107`	`108`	`{`
`108`	`109`	`/* endless idle loop with no priority at all */`
`109`	`110`	`for (;;) {`
	`111`	`+ rcu_idle_enter();`
`110`	`112`	`while (!need_resched()) {`
`111`	`113`	`void (*idle)(void);`
`112`	`114`
`@@ -121,6 +123,7 @@ void cpu_idle(void)`
`121`	`123`	`}`
`122`	`124`	`idle();`
`123`	`125`	`}`
	`126`	`+ rcu_idle_exit();`
`124`	`127`
`125`	`128`	`schedule_preempt_disabled();`
`126`	`129`	`}`