iscsit: remove incorrect unlock in iscsit_build_sendtargets_resp

Christoph Hellwig · Nicholas Bellinger · commit 904753da1835 · 2012-10-02T14:42:25.000-07:00
Fix a potential multiple spin-unlock -&gt; deadlock scenario during the
overflow check within iscsit_build_sendtargets_resp() as found by
sparse static checking.

Signed-off-by: Christoph Hellwig &lt;hch@lst.de&gt;
Cc: stable@vger.kernel.org
Signed-off-by: Nicholas Bellinger &lt;nab@linux-iscsi.org&gt;
diff --git a/drivers/target/iscsi/iscsi_target.c b/drivers/target/iscsi/iscsi_target.c
@@ -3274,7 +3274,6 @@ static int iscsit_build_sendtargets_response(struct iscsi_cmd *cmd)
 		len += 1;
 
 		if ((len + payload_len) > buffer_len) {
-			spin_unlock(&tiqn->tiqn_tpg_lock);
 			end_of_buf = 1;
 			goto eob;
 		}

Original file line number	Diff line number	Diff line change
`@@ -3274,7 +3274,6 @@ static int iscsit_build_sendtargets_response(struct iscsi_cmd *cmd)`
`3274`	`3274`	`len += 1;`
`3275`	`3275`
`3276`	`3276`	`if ((len + payload_len) > buffer_len) {`
`3277`		`- spin_unlock(&tiqn->tiqn_tpg_lock);`
`3278`	`3277`	`end_of_buf = 1;`
`3279`	`3278`	`goto eob;`
`3280`	`3279`	`}`