Add element to success call with test. Fixes jquery-validation#60

mlynch · jzaefferer · commit a8568232a6f2 · 2012-05-07T11:30:10.000+02:00
diff --git a/jquery.validate.js b/jquery.validate.js
@@ -703,7 +703,7 @@ $.extend($.validator, {
 				if ( typeof this.settings.success === "string" ) {
 					label.addClass( this.settings.success );
 				} else {
-					this.settings.success( label );
+					this.settings.success( label, element );
 				}
 			}
 			this.toShow = this.toShow.add(label);
diff --git a/test/test.js b/test/test.js
@@ -875,6 +875,17 @@ test("success isn't called for optional elements", function() {
 	equal( 0, $("#testForm1 label").size() );
 });
 
+test("success callback with element", function() {
+	expect(1);
+	var v = $("#userForm").validate({
+		success: function( label, element ) {
+			equal( element, $('#username').get(0) );
+		}
+	});
+	$("#username").val("hi");
+	v.form();
+});
+
 test("all rules are evaluated even if one returns a dependency-mistmatch", function() {
 	expect(6);
 	equal( "", $("#firstname").removeClass().val() );

Original file line number	Diff line number	Diff line change
`@@ -703,7 +703,7 @@ $.extend($.validator, {`
`703`	`703`	`if ( typeof this.settings.success === "string" ) {`
`704`	`704`	`label.addClass( this.settings.success );`
`705`	`705`	`} else {`
`706`		`- this.settings.success( label );`
	`706`	`+ this.settings.success( label, element );`
`707`	`707`	`}`
`708`	`708`	`}`
`709`	`709`	`this.toShow = this.toShow.add(label);`