Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: rust-lang/compiler-builtins
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: compiler_builtins-v0.1.160
Choose a base ref
...
head repository: rust-lang/compiler-builtins
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: master
Choose a head ref
  • 12 commits
  • 36 files changed
  • 1 contributor

Commits on Jun 1, 2025

  1. Configuration menu
    Copy the full SHA
    81609be View commit details
    Browse the repository at this point in the history
  2. Upgrade all dependencies to the latest available version

    In particular, this includes a fix to `iai-callgrind` that will allow us
    to simplify our benchmark runner.
    tgross35 committed Jun 1, 2025
    Configuration menu
    Copy the full SHA
    7c12df1 View commit details
    Browse the repository at this point in the history

Commits on Jun 2, 2025

  1. Configuration menu
    Copy the full SHA
    4f943d4 View commit details
    Browse the repository at this point in the history
  2. ci: Refactor benchmark regression checks

    iai-callgrind now correctly exits with error if regressions were found
    [1], so we no longer need to check for regressions manually. Remove this
    check and instead exit based on the exit status of the benchmark run.
    
    [1] iai-callgrind/iai-callgrind#337
    tgross35 committed Jun 2, 2025
    Configuration menu
    Copy the full SHA
    e211ac6 View commit details
    Browse the repository at this point in the history
  3. libm-test: Fix unintentional skips in binop_common

    `binop_common` emits a `SKIP` that is intended to apply only to
    `copysign`, but is instead applying to all binary operators. Correct the
    general case but leave the currently-failing `maximum_num` tests as a
    FIXME, to be resolved separately in [1].
    
    Also simplify skip logic and NaN checking, and add a few more `copysign`
    checks.
    
    [1]: #939
    tgross35 committed Jun 2, 2025
    Configuration menu
    Copy the full SHA
    da8433d View commit details
    Browse the repository at this point in the history
  4. compiler-builtins: Eliminate symlinks

    compiler-builtins has a symlink to the `libm` source directory so the
    two crates can share files but still act as two separate crates. This
    causes problems with some sysroot-related tooling, however, since
    directory symlinks seem to not be supported.
    
    The reason this was a symlink in the first place is that there isn't an
    easy for Cargo to publish two crates that share source (building works
    fine but publishing rejects `include`d files from parent directories, as
    well as nested package roots). However, after the switch to a subtree,
    we no longer need to publish compiler-builtins; this means that we can
    eliminate the link and just use `#[path]`.
    
    Similarly, the LICENSE file was symlinked so it could live in the
    repository root but be included in the package. This is also removed as
    it caused problems with the dist job (error from bootstrap's
    `tarball.rs`, "generated a symlink in a tarball").
    
    If we need to publish compiler-builtins again for any reason, it would
    be easy to revert these changes in a preprocess step.
    tgross35 committed Jun 2, 2025
    Configuration menu
    Copy the full SHA
    3c30d8c View commit details
    Browse the repository at this point in the history

Commits on Jun 4, 2025

  1. Replace the musl submodule with a download script

    The submodule was causing issues in rust-lang/rust, so eliminiate it
    here. `build-musl` is also removed from `libm-test`'s default features
    so the crate doesn't need to be built by default.
    tgross35 committed Jun 4, 2025
    Configuration menu
    Copy the full SHA
    f1c4a11 View commit details
    Browse the repository at this point in the history
  2. Add an empty rust-version file

    This will be used by `josh` tooling.
    tgross35 committed Jun 4, 2025
    Configuration menu
    Copy the full SHA
    9e0cc1d View commit details
    Browse the repository at this point in the history
  3. Add tooling for josh syncs

    Create a crate that handles pulling from and pushing to rust-lang/rust.
    This can be invoked with the following:
    
        $ cargo run -p josh-sync -- rustc-pull
        $ RUSTC_GIT=/path/to/rust/checkout cargo run -p josh-sync -- rustc-push <username>
    tgross35 committed Jun 4, 2025
    Configuration menu
    Copy the full SHA
    ded114b View commit details
    Browse the repository at this point in the history
  4. Update the upstream Rust version

    To prepare for merging from rust-lang/rust, set the version file to:
    
        df8102fe5f Auto merge of #142002 - onur-ozkan:follow-ups2, r=jieyouxu
    tgross35 committed Jun 4, 2025
    Configuration menu
    Copy the full SHA
    162576f View commit details
    Browse the repository at this point in the history
  5. Merge ref 'df8102fe5f24:/library/compiler-builtins' from https://gith…

    …ub.com/rust-lang/rust
    
    Pull recent changes from rust-lang/rust via Josh.
    
    Upstream ref: df8102fe5f24f28a918660b0cd918d7331c3896e
    Filtered ref: 3c30d8c
    tgross35 committed Jun 4, 2025
    Configuration menu
    Copy the full SHA
    5c3d8f2 View commit details
    Browse the repository at this point in the history
  6. panic-handler: Remove the no_core feature

    This was introduced before `#[panic_handler]` was stable, but should no
    longer be needed. Additionally, we only need it for
    `builtins-test-intrinsics`, not as a dependency of `compiler-builtins`.
    tgross35 committed Jun 4, 2025
    Configuration menu
    Copy the full SHA
    cd0f202 View commit details
    Browse the repository at this point in the history
Loading