From faba49b2d0c5b85be0ee7b9e35b5d3d37bfa563a Mon Sep 17 00:00:00 2001 From: Eric Huss Date: Sat, 1 Apr 2023 12:54:43 -0700 Subject: [PATCH 1/2] Remove "identifying the range of PRs". This section is no longer needed, since `cargo-bisect-rustc` will display the list of PRs automatically. --- src/notification-groups/cleanup-crew.md | 27 ------------------------- 1 file changed, 27 deletions(-) diff --git a/src/notification-groups/cleanup-crew.md b/src/notification-groups/cleanup-crew.md index 436b51fd1..ce53f41f6 100644 --- a/src/notification-groups/cleanup-crew.md +++ b/src/notification-groups/cleanup-crew.md @@ -85,30 +85,3 @@ can also ask questions at the Zulip stream [cargo-bisect-rustc]: https://github.com/rust-lang/cargo-bisect-rustc/ [learn]: https://blog.rust-lang.org/inside-rust/2019/12/18/bisecting-rust-compiler.html [zcbr]: https://rust-lang.zulipchat.com/#narrow/stream/217417-t-compiler.2Fcargo-bisect-rustc - -### identifying the range of PRs in a nightly - -If the regression occurred more than 90 days ago, then -cargo-bisect-rustc will not able to identify the particular PR that -caused the regression, just the nightly build. In that case, we can -identify the set of PRs that this corresponds to by using the git -history. - -The command `rustc +nightly -vV` will cause rustc to output a number -of useful bits of version info, including the `commit-hash`. Given the -commit-hash of two nightly versions, you can find all of PRs that have -landed in between by taking the following steps: - -1. Go to an update checkout of the [rust-lang/rust] repository -2. Execute the command `git log --author=bors --format=oneline SHA1..SHA2` - * This will list out all of the commits by bors, which is our merge bot - * Each commit corresponds to one PR, and information about the PR should be in the description -3. Copy and paste that information into the bug report - -Often, just eye-balling the PR descriptions (which are included in the -commit messages) will give you a good idea which one likely caused the -problem. But if you're unsure feel free to just ping the compiler team -(`@rust-lang/compiler`) or else to ping the authors of the PR -themselves. - -[rust-lang/rust]: https://github.com/rust-lang/rust/ From 322dd504a40b517e2ebb99b2cb9f680a9b735443 Mon Sep 17 00:00:00 2001 From: Eric Huss Date: Sat, 1 Apr 2023 12:57:52 -0700 Subject: [PATCH 2/2] Update some links and information for cargo-bisect-rustc --- src/compiler-debugging.md | 2 +- src/fuzzing.md | 2 +- src/notification-groups/cleanup-crew.md | 10 ++++++---- 3 files changed, 8 insertions(+), 6 deletions(-) diff --git a/src/compiler-debugging.md b/src/compiler-debugging.md index 0a98f36ee..65c3cadbb 100644 --- a/src/compiler-debugging.md +++ b/src/compiler-debugging.md @@ -269,7 +269,7 @@ on *why* it was changed. See [this tutorial][bisect-tutorial] on how to use it. [bisect]: https://github.com/rust-lang/cargo-bisect-rustc -[bisect-tutorial]: https://github.com/rust-lang/cargo-bisect-rustc/blob/master/TUTORIAL.md +[bisect-tutorial]: https://rust-lang.github.io/cargo-bisect-rustc/tutorial.html ## Downloading Artifacts from Rust's CI diff --git a/src/fuzzing.md b/src/fuzzing.md index bc7f0a0a2..3fb1add01 100644 --- a/src/fuzzing.md +++ b/src/fuzzing.md @@ -87,7 +87,7 @@ Here are a few things you can do to help the Rust project after filing an ICE. - Minimize the test case (see below) - Add the minimal test case to [Glacier][glacier] -[bisect]: https://github.com/rust-lang/cargo-bisect-rustc/blob/master/TUTORIAL.md +[bisect]: https://rust-lang.github.io/cargo-bisect-rustc/ ## Minimization diff --git a/src/notification-groups/cleanup-crew.md b/src/notification-groups/cleanup-crew.md index ce53f41f6..2e7b1766c 100644 --- a/src/notification-groups/cleanup-crew.md +++ b/src/notification-groups/cleanup-crew.md @@ -77,11 +77,13 @@ various builds of rustc. For recent regressions, it is even able to use the builds from our CI to track down the regression to a specific PR; for older regressions, it will simply identify a nightly. -To learn to use [cargo-bisect-rustc], check out [this blog -post][learn], which gives a quick introduction to how it works. You -can also ask questions at the Zulip stream -[`#t-compiler/cargo-bisect-rustc`][zcbr], or help in improving the tool. +To learn to use [cargo-bisect-rustc], check out [this blog post][learn], which +gives a quick introduction to how it works. Additionally, there is a [Guide] +which goes into more detail on how to use it. You can also ask questions at +the Zulip stream [`#t-compiler/cargo-bisect-rustc`][zcbr], or help in +improving the tool. [cargo-bisect-rustc]: https://github.com/rust-lang/cargo-bisect-rustc/ [learn]: https://blog.rust-lang.org/inside-rust/2019/12/18/bisecting-rust-compiler.html [zcbr]: https://rust-lang.zulipchat.com/#narrow/stream/217417-t-compiler.2Fcargo-bisect-rustc +[Guide]: https://rust-lang.github.io/cargo-bisect-rustc/