Rewrite select! as a procedural macro #1363
Conversation
This commit removes the old macro_rules tt muncher parser implementation of the select! macro and replaces it with a procedural macro that accomplishes the same task, but which should be dramatically simpler to read and modify.
|
Haven't read the implementation of the procedural macro yet (will get to it later today) but a quick idea regarding the duplicated documentation -- you could have futures-util provide: #[doc(hidden)]
#[macro_export]
macro_rules! with_documentation_of_select_macro {
($item:item) => {
/// Polls multiple futures and streams simultaneously, ...
$item
};
}which both it and futures use. I forget whether doc comments can be added to an |
| proc-macro = true | ||
|
|
||
| [features] | ||
| std = [] |
There was a problem hiding this comment.
At some point I figured we could use this to turn off rand support, though I've left that unimplemented for now. Perhaps we'd require the user to provide a link-time function that could be used to shuffle arrays?
There was a problem hiding this comment.
Yep, something like that sounds possible. I was thinking I might take a look at getting it working on no_std, then realised it wouldn’t work without await! support.
There was a problem hiding this comment.
Right, await! is the big blocker for getting no-std.
This commit removes the old macro_rules tt muncher parser
implementation of the select! macro and replaces it with
a procedural macro that accomplishes the same task, but which
should be dramatically simpler to read and modify.