feat(state): make sideEffectFn optional in ActionEffects

hoebbelsB · hoebbelsB · commit 22e45764ea31 · 2023-10-17T01:29:32.000+02:00
diff --git a/libs/state/actions/src/lib/rx-actions.spec.ts b/libs/state/actions/src/lib/rx-actions.spec.ts
@@ -102,9 +102,11 @@ describe('actions fn', () => {
     const t = { se: () => void 0 };
     const spyBehavior = jest.fn();
     const dummyBehaviour = (o$) => o$.pipe(tap(spyBehavior));
-    const spyT = jest.fn((_: any) => void 0);
 
-    const sub = component.actions.onProp(dummyBehaviour, spyT);
+    const sub = component.actions.onProp(dummyBehaviour);
+    component.actions.prop('p');
+    expect(spyBehavior).toHaveBeenCalledTimes(1);
+    sub();
     component.actions.prop('p');
     expect(spyBehavior).toHaveBeenCalledTimes(1);
   });
diff --git a/libs/state/actions/src/lib/types.ts b/libs/state/actions/src/lib/types.ts
@@ -51,7 +51,7 @@ export type ActionObservables<T extends Actions> = {
 export type ActionEffects<T extends Actions, O = T> = {
   [K in ExtractString<T> as `on${Capitalize<K>}`]: (
     fn: OperatorFunction<T[K], T[K] | any>,
-    sideEffectFn: (value: T[K] | any) => void
+    sideEffectFn?: (value: T[K] | any) => void
   ) => () => void;
 };
 
