Merge pull request #1393 from rx-angular/turn-off-no-input-rename

hoebbelsB · web-flow · commit 2e94f9df56fa · 2022-08-09T12:21:14.000+02:00
chore: turn-off no-input-rename eslint rule
diff --git a/libs/template/.eslintrc.json b/libs/template/.eslintrc.json
@@ -41,6 +41,7 @@
             "style": "kebab-case"
           }
         ],
+        "@angular-eslint/no-input-rename": "off",
         "@typescript-eslint/no-non-null-assertion": "warn"
       }
     },
diff --git a/libs/template/experimental/for/src/lib/for.directive.ts b/libs/template/experimental/for/src/lib/for.directive.ts
@@ -14,14 +14,14 @@ import {
   TrackByFunction,
   ViewContainerRef,
 } from '@angular/core';
+import { coerceDistinctWith } from '@rx-angular/cdk/coercing';
+import { RxStrategyProvider } from '@rx-angular/cdk/render-strategies';
 import {
   createListTemplateManager,
   RxListManager,
   RxListViewComputedContext,
   RxListViewContext,
 } from '@rx-angular/cdk/template';
-import { RxStrategyProvider } from '@rx-angular/cdk/render-strategies';
-import { coerceDistinctWith } from '@rx-angular/cdk/coercing';
 
 import { Observable, ReplaySubject, Subject, Subscription } from 'rxjs';
 import { RxForViewContext } from './for-view-context';
@@ -364,8 +364,6 @@ export class RxFor<T, U extends NgIterable<T> = NgIterable<T>>
     this.strategyInput$.next(strategyName);
   }
 
-  /* @todo: rename to `rxRenderParent`? */
-  /* eslint-disable @angular-eslint/no-input-rename */
   /**
    * @description
    *  If `parent` is set to `true` (default to `false`), `*rxFor` will automatically detect every other `Component` where its
diff --git a/libs/template/experimental/if/src/lib/if.directive.ts b/libs/template/experimental/if/src/lib/if.directive.ts
@@ -8,30 +8,30 @@ import {
   OnInit,
   SimpleChanges,
   TemplateRef,
-  ViewContainerRef
+  ViewContainerRef,
 } from '@angular/core';
 import { coerceAllFactory, coerceObservable } from '@rx-angular/cdk/coercing';
 import {
   createTemplateNotifier,
-  RxNotificationKind
+  RxNotificationKind,
 } from '@rx-angular/cdk/notifications';
 import { RxStrategyProvider } from '@rx-angular/cdk/render-strategies';
 import {
   createTemplateManager,
-  RxTemplateManager
+  RxTemplateManager,
 } from '@rx-angular/cdk/template';
 import {
   NextObserver,
   Observable,
   ReplaySubject,
   Subject,
-  Subscription
+  Subscription,
 } from 'rxjs';
 import { mergeAll } from 'rxjs/operators';
 import {
   RxIfTemplateNames,
   rxIfTemplateNames,
-  RxIfViewContext
+  RxIfViewContext,
 } from './model/index';
 
 @Directive({
@@ -52,7 +52,6 @@ export class RxIf<U> implements OnInit, OnDestroy {
     this.observablesHandler.next(coerceObservable(potentialObservable));
   }
 
-  /* eslint-disable @angular-eslint/no-input-rename */
   @Input('rxIfStrategy')
   set strategy(strategyName: Observable<string> | string | null | undefined) {
     this.strategyHandler.next(strategyName);
diff --git a/libs/template/let/src/lib/let.directive.ts b/libs/template/let/src/lib/let.directive.ts
@@ -13,22 +13,22 @@ import {
   TemplateRef,
   ViewContainerRef,
 } from '@angular/core';
-import {
-  createTemplateManager,
-  RxTemplateManager,
-  RxBaseTemplateNames,
-  RxViewContext,
-} from '@rx-angular/cdk/template';
-import {
-  RxStrategyProvider,
-  RxStrategyNames,
-} from '@rx-angular/cdk/render-strategies';
 import { coerceAllFactory } from '@rx-angular/cdk/coercing';
 import {
   createTemplateNotifier,
   RxNotification,
   RxNotificationKind,
 } from '@rx-angular/cdk/notifications';
+import {
+  RxStrategyNames,
+  RxStrategyProvider,
+} from '@rx-angular/cdk/render-strategies';
+import {
+  createTemplateManager,
+  RxBaseTemplateNames,
+  RxTemplateManager,
+  RxViewContext,
+} from '@rx-angular/cdk/template';
 
 import {
   defer,
@@ -299,8 +299,6 @@ export class LetDirective<U> implements OnInit, OnDestroy, OnChanges {
     this._renderObserver = callback;
   }
 
-  /* @todo: Rename to `rxRenderParent`? */
-  // eslint-disable-next-line @angular-eslint/no-input-rename
   @Input('rxLetParent') renderParent = this.strategyProvider.config.parent;
 
   @Input('rxLetPatchZone') patchZone = this.strategyProvider.config.patchZone;

Original file line number	Diff line number	Diff line change
`@@ -41,6 +41,7 @@`
`41`	`41`	`"style": "kebab-case"`
`42`	`42`	`}`
`43`	`43`	`],`
	`44`	`+ "@angular-eslint/no-input-rename": "off",`
`44`	`45`	`"@typescript-eslint/no-non-null-assertion": "warn"`
`45`	`46`	`}`
`46`	`47`	`},`