chore: turn-off no-input-rename eslint rule

edbzn · edbzn · commit 84e36e54f39a · 2022-08-09T10:38:33.000+02:00
Resolve #1392
diff --git a/libs/template/.eslintrc.json b/libs/template/.eslintrc.json
@@ -41,6 +41,7 @@
             "style": "kebab-case"
           }
         ],
+        "@angular-eslint/no-input-rename": "off",
         "@typescript-eslint/no-non-null-assertion": "warn"
       }
     },
diff --git a/libs/template/experimental/for/src/lib/for.directive.ts b/libs/template/experimental/for/src/lib/for.directive.ts
@@ -12,16 +12,16 @@ import {
   OnInit,
   TemplateRef,
   TrackByFunction,
-  ViewContainerRef,
+  ViewContainerRef
 } from '@angular/core';
+import { coerceDistinctWith } from '@rx-angular/cdk/coercing';
+import { RxStrategyProvider } from '@rx-angular/cdk/render-strategies';
 import {
   createListTemplateManager,
   RxListManager,
   RxListViewComputedContext,
-  RxListViewContext,
+  RxListViewContext
 } from '@rx-angular/cdk/template';
-import { RxStrategyProvider } from '@rx-angular/cdk/render-strategies';
-import { coerceDistinctWith } from '@rx-angular/cdk/coercing';
 
 import { Observable, ReplaySubject, Subject, Subscription } from 'rxjs';
 import { RxForViewContext } from './for-view-context';
@@ -364,8 +364,6 @@ export class RxFor<T, U extends NgIterable<T> = NgIterable<T>>
     this.strategyInput$.next(strategyName);
   }
 
-  /* @todo: rename to `rxRenderParent`? */
-  /* eslint-disable @angular-eslint/no-input-rename */
   /**
    * @description
    *  If `parent` is set to `true` (default to `false`), `*rxFor` will automatically detect every other `Component` where its
diff --git a/libs/template/experimental/if/src/lib/if.directive.ts b/libs/template/experimental/if/src/lib/if.directive.ts
@@ -52,7 +52,6 @@ export class RxIf<U> implements OnInit, OnDestroy {
     this.observablesHandler.next(coerceObservable(potentialObservable));
   }
 
-  /* eslint-disable @angular-eslint/no-input-rename */
   @Input('rxIfStrategy')
   set strategy(strategyName: Observable<string> | string | null | undefined) {
     this.strategyHandler.next(strategyName);
diff --git a/libs/template/let/src/lib/let.directive.ts b/libs/template/let/src/lib/let.directive.ts
@@ -11,24 +11,20 @@ import {
   Output,
   SimpleChanges,
   TemplateRef,
-  ViewContainerRef,
+  ViewContainerRef
 } from '@angular/core';
-import {
-  createTemplateManager,
-  RxTemplateManager,
-  RxBaseTemplateNames,
-  RxViewContext,
-} from '@rx-angular/cdk/template';
-import {
-  RxStrategyProvider,
-  RxStrategyNames,
-} from '@rx-angular/cdk/render-strategies';
 import { coerceAllFactory } from '@rx-angular/cdk/coercing';
 import {
   createTemplateNotifier,
   RxNotification,
-  RxNotificationKind,
+  RxNotificationKind
 } from '@rx-angular/cdk/notifications';
+import {
+  RxStrategyNames, RxStrategyProvider
+} from '@rx-angular/cdk/render-strategies';
+import {
+  createTemplateManager, RxBaseTemplateNames, RxTemplateManager, RxViewContext
+} from '@rx-angular/cdk/template';
 
 import {
   defer,
@@ -38,7 +34,7 @@ import {
   ObservableInput,
   ReplaySubject,
   Subject,
-  Subscription,
+  Subscription
 } from 'rxjs';
 import { mergeAll } from 'rxjs/operators';
 
@@ -299,8 +295,6 @@ export class LetDirective<U> implements OnInit, OnDestroy, OnChanges {
     this._renderObserver = callback;
   }
 
-  /* @todo: Rename to `rxRenderParent`? */
-  // eslint-disable-next-line @angular-eslint/no-input-rename
   @Input('rxLetParent') renderParent = this.strategyProvider.config.parent;
 
   @Input('rxLetPatchZone') patchZone = this.strategyProvider.config.patchZone;

Original file line number	Diff line number	Diff line change
`@@ -41,6 +41,7 @@`
`41`	`41`	`"style": "kebab-case"`
`42`	`42`	`}`
`43`	`43`	`],`
	`44`	`+ "@angular-eslint/no-input-rename": "off",`
`44`	`45`	`"@typescript-eslint/no-non-null-assertion": "warn"`
`45`	`46`	`}`
`46`	`47`	`},`
Original file line number	Diff line number	Diff line change
`@@ -52,7 +52,6 @@ export class RxIf<U> implements OnInit, OnDestroy {`
`52`	`52`	`this.observablesHandler.next(coerceObservable(potentialObservable));`
`53`	`53`	`}`
`54`	`54`
`55`		`- /* eslint-disable @angular-eslint/no-input-rename */`
`56`	`55`	`@Input('rxIfStrategy')`
`57`	`56`	`set strategy(strategyName: Observable<string> \| string \| null \| undefined) {`
`58`	`57`	`this.strategyHandler.next(strategyName);`