Skip to content

Commit 43a8ac3

Browse files
rzcoderrzcoder
committed
Merge remote-tracking branch 'origin/dev' into master2
# Conflicts: # README.md # src/schemes/pkcs1.js
2 parents 5f169c8 + 955ae2b commit 43a8ac3

File tree

9 files changed

+59
-46
lines changed

9 files changed

+59
-46
lines changed

‎README.md

+5-2
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ console.log('decrypted: ', decrypted);
2727
```shell
2828
npm install node-rsa
2929
```
30-
> <sub>Requires nodejs >= 0.10.x or io.js >= 1.x</sub>
30+
> <sub>Requires nodejs >= 5.10
3131
3232
### Testing
3333

@@ -237,9 +237,12 @@ Questions, comments, bug reports, and pull requests are all welcome.
237237

238238
## Changelog
239239

240+
### 1.0.0
241+
* **Possible breaking changes** `new Buffer()` call as deprecated was replaced by `Buffer.from` & `Buffer.alloc`. As result dropped support for node version < 5.10.
242+
240243
### 0.4.2
241244
* `no padding` scheme will padded data with zeros on all environments.
242-
245+
243246
### 0.4.1
244247
* `PKCS1 no padding` scheme support.
245248

‎src/NodeRSA.js

+3-3
Original file line numberDiff line numberDiff line change
@@ -289,7 +289,7 @@ module.exports = (function () {
289289
*/
290290
NodeRSA.prototype.$$decryptKey = function (usePublic, buffer, encoding) {
291291
try {
292-
buffer = _.isString(buffer) ? new Buffer(buffer, 'base64') : buffer;
292+
buffer = _.isString(buffer) ? Buffer.from(buffer, 'base64') : buffer;
293293
var res = this.keyPair.decrypt(buffer, usePublic);
294294

295295
if (res === null) {
@@ -366,11 +366,11 @@ module.exports = (function () {
366366
*/
367367
NodeRSA.prototype.$getDataForEncrypt = function (buffer, encoding) {
368368
if (_.isString(buffer) || _.isNumber(buffer)) {
369-
return new Buffer('' + buffer, encoding || 'utf8');
369+
return Buffer.from('' + buffer, encoding || 'utf8');
370370
} else if (Buffer.isBuffer(buffer)) {
371371
return buffer;
372372
} else if (_.isObject(buffer)) {
373-
return new Buffer(JSON.stringify(buffer));
373+
return Buffer.from(JSON.stringify(buffer));
374374
} else {
375375
throw Error("Unexpected data type");
376376
}

‎src/encryptEngines/io.js

+6-4
Original file line numberDiff line numberDiff line change
@@ -7,8 +7,9 @@ module.exports = function (keyPair, options) {
77

88
return {
99
encrypt: function (buffer, usePrivate) {
10+
var padding;
1011
if (usePrivate) {
11-
var padding = constants.RSA_PKCS1_PADDING;
12+
padding = constants.RSA_PKCS1_PADDING;
1213
if (options.encryptionSchemeOptions && options.encryptionSchemeOptions.padding) {
1314
padding = options.encryptionSchemeOptions.padding;
1415
}
@@ -17,7 +18,7 @@ module.exports = function (keyPair, options) {
1718
padding: padding
1819
}, buffer);
1920
} else {
20-
var padding = constants.RSA_PKCS1_OAEP_PADDING;
21+
padding = constants.RSA_PKCS1_OAEP_PADDING;
2122
if (options.encryptionScheme === 'pkcs1') {
2223
padding = constants.RSA_PKCS1_PADDING;
2324
}
@@ -38,8 +39,9 @@ module.exports = function (keyPair, options) {
3839
},
3940

4041
decrypt: function (buffer, usePublic) {
42+
var padding;
4143
if (usePublic) {
42-
var padding = constants.RSA_PKCS1_PADDING;
44+
padding = constants.RSA_PKCS1_PADDING;
4345
if (options.encryptionSchemeOptions && options.encryptionSchemeOptions.padding) {
4446
padding = options.encryptionSchemeOptions.padding;
4547
}
@@ -48,7 +50,7 @@ module.exports = function (keyPair, options) {
4850
padding: padding
4951
}, buffer);
5052
} else {
51-
var padding = constants.RSA_PKCS1_OAEP_PADDING;
53+
padding = constants.RSA_PKCS1_OAEP_PADDING;
5254
if (options.encryptionScheme === 'pkcs1') {
5355
padding = constants.RSA_PKCS1_PADDING;
5456
}

‎src/formats/pkcs1.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ module.exports = {
4949
var pem = data.replace('-----BEGIN RSA PRIVATE KEY-----', '')
5050
.replace('-----END RSA PRIVATE KEY-----', '')
5151
.replace(/\s+|\n\r|\n|\r$/gm, '');
52-
buffer = new Buffer(pem, 'base64');
52+
buffer = Buffer.from(pem, 'base64');
5353
} else {
5454
throw Error('Unsupported key format');
5555
}
@@ -106,7 +106,7 @@ module.exports = {
106106
var pem = data.replace('-----BEGIN RSA PUBLIC KEY-----', '')
107107
.replace('-----END RSA PUBLIC KEY-----', '')
108108
.replace(/\s+|\n\r|\n|\r$/gm, '');
109-
buffer = new Buffer(pem, 'base64');
109+
buffer = Buffer.from(pem, 'base64');
110110
}
111111
} else if (Buffer.isBuffer(data)) {
112112
buffer = data;

‎src/formats/pkcs8.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,7 @@ module.exports = {
6060
var pem = data.replace('-----BEGIN PRIVATE KEY-----', '')
6161
.replace('-----END PRIVATE KEY-----', '')
6262
.replace(/\s+|\n\r|\n|\r$/gm, '');
63-
buffer = new Buffer(pem, 'base64');
63+
buffer = Buffer.from(pem, 'base64');
6464
} else {
6565
throw Error('Unsupported key format');
6666
}
@@ -136,7 +136,7 @@ module.exports = {
136136
var pem = data.replace('-----BEGIN PUBLIC KEY-----', '')
137137
.replace('-----END PUBLIC KEY-----', '')
138138
.replace(/\s+|\n\r|\n|\r$/gm, '');
139-
buffer = new Buffer(pem, 'base64');
139+
buffer = Buffer.from(pem, 'base64');
140140
}
141141
} else if (Buffer.isBuffer(data)) {
142142
buffer = data;

‎src/libs/jsbn.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -829,7 +829,7 @@ function bnToByteArray() {
829829
* @returns {Buffer}
830830
*/
831831
function bnToBuffer(trimOrSize) {
832-
var res = new Buffer(this.toByteArray());
832+
var res = Buffer.from(this.toByteArray());
833833
if (trimOrSize === true && res[0] === 0) {
834834
res = res.slice(1);
835835
} else if (_.isNumber(trimOrSize)) {
@@ -841,7 +841,7 @@ function bnToBuffer(trimOrSize) {
841841
}
842842
return res.slice(res.length - trimOrSize);
843843
} else if (res.length < trimOrSize) {
844-
var padded = new Buffer(trimOrSize);
844+
var padded = Buffer.alloc(trimOrSize);
845845
padded.fill(0, 0, trimOrSize - res.length);
846846
res.copy(padded, trimOrSize - res.length);
847847
return padded;

‎src/schemes/oaep.js

+6-6
Original file line numberDiff line numberDiff line change
@@ -44,8 +44,8 @@ module.exports.eme_oaep_mgf1 = function (seed, maskLength, hashFunction) {
4444
hashFunction = hashFunction || DEFAULT_HASH_FUNCTION;
4545
var hLen = module.exports.digestLength[hashFunction];
4646
var count = Math.ceil(maskLength / hLen);
47-
var T = new Buffer(hLen * count);
48-
var c = new Buffer(4);
47+
var T = Buffer.alloc(hLen * count);
48+
var c = Buffer.alloc(4);
4949
for (var i = 0; i < count; ++i) {
5050
var hash = crypt.createHash(hashFunction);
5151
hash.update(seed);
@@ -75,7 +75,7 @@ module.exports.makeScheme = function (key, options) {
7575
Scheme.prototype.encPad = function (buffer) {
7676
var hash = this.options.encryptionSchemeOptions.hash || DEFAULT_HASH_FUNCTION;
7777
var mgf = this.options.encryptionSchemeOptions.mgf || module.exports.eme_oaep_mgf1;
78-
var label = this.options.encryptionSchemeOptions.label || new Buffer(0);
78+
var label = this.options.encryptionSchemeOptions.label || Buffer.alloc(0);
7979
var emLen = this.key.encryptedDataLength;
8080

8181
var hLen = module.exports.digestLength[hash];
@@ -90,7 +90,7 @@ module.exports.makeScheme = function (key, options) {
9090
lHash.update(label);
9191
lHash = lHash.digest();
9292

93-
var PS = new Buffer(emLen - buffer.length - 2 * hLen - 1); // Padding "String"
93+
var PS = Buffer.alloc(emLen - buffer.length - 2 * hLen - 1); // Padding "String"
9494
PS.fill(0); // Fill the buffer with octets of 0
9595
PS[PS.length - 1] = 1;
9696

@@ -113,7 +113,7 @@ module.exports.makeScheme = function (key, options) {
113113
}
114114
// seed = maskedSeed
115115

116-
var em = new Buffer(1 + seed.length + DB.length);
116+
var em = Buffer.alloc(1 + seed.length + DB.length);
117117
em[0] = 0;
118118
seed.copy(em, 1);
119119
DB.copy(em, 1 + seed.length);
@@ -133,7 +133,7 @@ module.exports.makeScheme = function (key, options) {
133133
Scheme.prototype.encUnPad = function (buffer) {
134134
var hash = this.options.encryptionSchemeOptions.hash || DEFAULT_HASH_FUNCTION;
135135
var mgf = this.options.encryptionSchemeOptions.mgf || module.exports.eme_oaep_mgf1;
136-
var label = this.options.encryptionSchemeOptions.label || new Buffer(0);
136+
var label = this.options.encryptionSchemeOptions.label || Buffer.alloc(0);
137137

138138
var hLen = module.exports.digestLength[hash];
139139

‎src/schemes/pkcs1.js

+25-17
Original file line numberDiff line numberDiff line change
@@ -6,15 +6,15 @@ var BigInteger = require('../libs/jsbn');
66
var crypt = require('crypto');
77
var constants = require('constants');
88
var SIGN_INFO_HEAD = {
9-
md2: new Buffer('3020300c06082a864886f70d020205000410', 'hex'),
10-
md5: new Buffer('3020300c06082a864886f70d020505000410', 'hex'),
11-
sha1: new Buffer('3021300906052b0e03021a05000414', 'hex'),
12-
sha224: new Buffer('302d300d06096086480165030402040500041c', 'hex'),
13-
sha256: new Buffer('3031300d060960864801650304020105000420', 'hex'),
14-
sha384: new Buffer('3041300d060960864801650304020205000430', 'hex'),
15-
sha512: new Buffer('3051300d060960864801650304020305000440', 'hex'),
16-
ripemd160: new Buffer('3021300906052b2403020105000414', 'hex'),
17-
rmd160: new Buffer('3021300906052b2403020105000414', 'hex')
9+
md2: Buffer.from('3020300c06082a864886f70d020205000410', 'hex'),
10+
md5: Buffer.from('3020300c06082a864886f70d020505000410', 'hex'),
11+
sha1: Buffer.from('3021300906052b0e03021a05000414', 'hex'),
12+
sha224: Buffer.from('302d300d06096086480165030402040500041c', 'hex'),
13+
sha256: Buffer.from('3031300d060960864801650304020105000420', 'hex'),
14+
sha384: Buffer.from('3041300d060960864801650304020205000430', 'hex'),
15+
sha512: Buffer.from('3051300d060960864801650304020305000440', 'hex'),
16+
ripemd160: Buffer.from('3021300906052b2403020105000414', 'hex'),
17+
rmd160: Buffer.from('3021300906052b2403020105000414', 'hex')
1818
};
1919

2020
var SIGN_ALG_TO_HASH_ALIASES = {
@@ -42,7 +42,7 @@ module.exports.makeScheme = function (key, options) {
4242
};
4343

4444
/**
45-
* Pad input Buffer to encryptedDataLength bytes, and return new Buffer
45+
* Pad input Buffer to encryptedDataLength bytes, and return Buffer.from
4646
* alg: PKCS#1
4747
* @param buffer
4848
* @returns {Buffer}
@@ -55,20 +55,22 @@ module.exports.makeScheme = function (key, options) {
5555
}
5656
if (this.options.encryptionSchemeOptions && this.options.encryptionSchemeOptions.padding == constants.RSA_NO_PADDING) {
5757
//RSA_NO_PADDING treated like JAVA left pad with zero character
58-
return this.pkcs0pad(buffer);
58+
filled = Buffer.alloc(this.key.maxMessageLength - buffer.length);
59+
filled.fill(0);
60+
return Buffer.concat([filled, buffer]);
5961
}
6062

6163
/* Type 1: zeros padding for private key encrypt */
6264
if (options.type === 1) {
63-
filled = new Buffer(this.key.encryptedDataLength - buffer.length - 1);
65+
filled = Buffer.alloc(this.key.encryptedDataLength - buffer.length - 1);
6466
filled.fill(0xff, 0, filled.length - 1);
6567
filled[0] = 1;
6668
filled[filled.length - 1] = 0;
6769

6870
return Buffer.concat([filled, buffer]);
6971
} else {
7072
/* random padding for public key encrypt */
71-
filled = new Buffer(this.key.encryptedDataLength - buffer.length);
73+
filled = Buffer.alloc(this.key.encryptedDataLength - buffer.length);
7274
filled[0] = 0;
7375
filled[1] = 2;
7476
var rand = crypt.randomBytes(filled.length - 3);
@@ -96,7 +98,13 @@ module.exports.makeScheme = function (key, options) {
9698

9799
if (this.options.encryptionSchemeOptions && this.options.encryptionSchemeOptions.padding == constants.RSA_NO_PADDING) {
98100
//RSA_NO_PADDING treated like JAVA left pad with zero character
99-
return this.pkcs0unpad(buffer);
101+
var unPad;
102+
if (typeof buffer.lastIndexOf == "function") { //patch for old node version
103+
unPad = buffer.slice(buffer.lastIndexOf('\0') + 1, buffer.length);
104+
} else {
105+
unPad = buffer.slice(String.prototype.lastIndexOf.call(buffer, '\0') + 1, buffer.length);
106+
}
107+
return unPad;
100108
}
101109

102110
if (buffer.length < 4) {
@@ -157,7 +165,7 @@ module.exports.makeScheme = function (key, options) {
157165
hashAlgorithm = SIGN_ALG_TO_HASH_ALIASES[hashAlgorithm] || hashAlgorithm;
158166

159167
if (signature_encoding) {
160-
signature = new Buffer(signature, signature_encoding);
168+
signature = Buffer.from(signature, signature_encoding);
161169
}
162170

163171
var hasher = crypt.createHash(hashAlgorithm);
@@ -180,7 +188,7 @@ module.exports.makeScheme = function (key, options) {
180188
* @returns {*}
181189
*/
182190
Scheme.prototype.pkcs0pad = function (buffer) {
183-
var filled = new Buffer(this.key.maxMessageLength - buffer.length);
191+
var filled = Buffer.alloc(this.key.maxMessageLength - buffer.length);
184192
filled.fill(0);
185193
return Buffer.concat([filled, buffer]);
186194

@@ -216,7 +224,7 @@ module.exports.makeScheme = function (key, options) {
216224
throw Error('Key is too short for signing algorithm (' + hashAlgorithm + ')');
217225
}
218226

219-
var filled = new Buffer(this.key.encryptedDataLength - data.length - 1);
227+
var filled = Buffer.alloc(this.key.encryptedDataLength - data.length - 1);
220228
filled.fill(0xff, 0, filled.length - 1);
221229
filled[0] = 1;
222230
filled[filled.length - 1] = 0;

‎src/schemes/pss.js

+8-8
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ module.exports.makeScheme = function (key, options) {
4141

4242
Scheme.prototype.verify = function (buffer, signature, signature_encoding) {
4343
if (signature_encoding) {
44-
signature = new Buffer(signature, signature_encoding);
44+
signature = Buffer.from(signature, signature_encoding);
4545
}
4646
signature = new BigInteger(signature);
4747

@@ -78,7 +78,7 @@ module.exports.makeScheme = function (key, options) {
7878

7979
var salt = crypt.randomBytes(sLen);
8080

81-
var Mapostrophe = new Buffer(8 + hLen + sLen);
81+
var Mapostrophe = Buffer.alloc(8 + hLen + sLen);
8282
Mapostrophe.fill(0, 0, 8);
8383
mHash.copy(Mapostrophe, 8);
8484
salt.copy(Mapostrophe, 8 + mHash.length);
@@ -87,18 +87,18 @@ module.exports.makeScheme = function (key, options) {
8787
H.update(Mapostrophe);
8888
H = H.digest();
8989

90-
var PS = new Buffer(emLen - salt.length - hLen - 2);
90+
var PS = Buffer.alloc(emLen - salt.length - hLen - 2);
9191
PS.fill(0);
9292

93-
var DB = new Buffer(PS.length + 1 + salt.length);
93+
var DB = Buffer.alloc(PS.length + 1 + salt.length);
9494
PS.copy(DB);
9595
DB[PS.length] = 0x01;
9696
salt.copy(DB, PS.length + 1);
9797

9898
var dbMask = mgf(H, DB.length, hash);
9999

100100
// XOR DB and dbMask together
101-
var maskedDB = new Buffer(DB.length);
101+
var maskedDB = Buffer.alloc(DB.length);
102102
for (var i = 0; i < dbMask.length; i++) {
103103
maskedDB[i] = DB[i] ^ dbMask[i];
104104
}
@@ -107,7 +107,7 @@ module.exports.makeScheme = function (key, options) {
107107
var mask = 255 ^ (255 >> 8 - bits << 8 - bits);
108108
maskedDB[0] = maskedDB[0] & mask;
109109

110-
var EM = new Buffer(maskedDB.length + H.length + 1);
110+
var EM = Buffer.alloc(maskedDB.length + H.length + 1);
111111
maskedDB.copy(EM, 0);
112112
H.copy(EM, maskedDB.length);
113113
EM[EM.length - 1] = 0xbc;
@@ -135,7 +135,7 @@ module.exports.makeScheme = function (key, options) {
135135
return false;
136136
}
137137

138-
var DB = new Buffer(emLen - hLen - 1);
138+
var DB = Buffer.alloc(emLen - hLen - 1);
139139
EM.copy(DB, 0, 0, emLen - hLen - 1);
140140

141141
var mask = 0;
@@ -167,7 +167,7 @@ module.exports.makeScheme = function (key, options) {
167167

168168
var salt = DB.slice(DB.length - sLen);
169169

170-
var Mapostrophe = new Buffer(8 + hLen + sLen);
170+
var Mapostrophe = Buffer.alloc(8 + hLen + sLen);
171171
Mapostrophe.fill(0, 0, 8);
172172
mHash.copy(Mapostrophe, 8);
173173
salt.copy(Mapostrophe, 8 + mHash.length);

0 commit comments

Comments
 (0)