Fixed a issue when the key was generated by 1 bit smaller than specified

s.vychegzhanin · s.vychegzhanin · commit c061fdbf8474 · 2016-01-11T18:57:53.000+05:00
diff --git a/README.md b/README.md
@@ -209,6 +209,9 @@ Questions, comments, bug reports, and pull requests are all welcome.
 
 ## Changelog
 
+### 0.2.30
+ * Fixed a issue when the key was generated by 1 bit smaller than specified. It may slow down the generation of large keys.    
+
 ### 0.2.24
  * Now used old hash APIs for webpack compatible.
 
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "node-rsa",
-  "version": "0.2.26",
+  "version": "0.2.30",
   "description": "Node.js RSA library",
   "main": "src/NodeRSA.js",
   "scripts": {
diff --git a/src/libs/rsa.js b/src/libs/rsa.js
@@ -115,6 +115,9 @@ module.exports.Key = (function () {
             var phi = p1.multiply(q1);
             if (phi.gcd(ee).compareTo(BigInteger.ONE) === 0) {
                 this.n = this.p.multiply(this.q);
+                if (this.n.bitLength() < B) {
+                    continue;
+                }
                 this.d = ee.modInverse(phi);
                 this.dmp1 = this.d.mod(p1);
                 this.dmq1 = this.d.mod(q1);
@@ -303,10 +306,6 @@ module.exports.Key = (function () {
         this.cache = this.cache || {};
         // Bit & byte length
         this.cache.keyBitLength = this.n.bitLength();
-        if (this.cache.keyBitLength % 2 == 1) {
-            this.cache.keyBitLength = this.cache.keyBitLength + 1;
-        }
-
         this.cache.keyByteLength = (this.cache.keyBitLength + 6) >> 3;
     };
 

Original file line number	Diff line number	Diff line change
`@@ -1,6 +1,6 @@`
`1`	`1`	`{`
`2`	`2`	`"name": "node-rsa",`
`3`		`- "version": "0.2.26",`
	`3`	`+ "version": "0.2.30",`
`4`	`4`	`"description": "Node.js RSA library",`
`5`	`5`	`"main": "src/NodeRSA.js",`
`6`	`6`	`"scripts": {`