some comments

s.vychegzhanin · s.vychegzhanin · commit e045714c25eb · 2016-08-02T13:18:49.000+05:00
diff --git a/src/encryptEngines/js.js b/src/encryptEngines/js.js
@@ -8,6 +8,7 @@ module.exports = function (keyPair, options) {
         encrypt: function (buffer, usePrivate) {
             var m, c;
             if (usePrivate) {
+                /* Type 1: zeros padding for private key encrypt */
                 m = new BigInteger(pkcs1Scheme.encPad(buffer, {type: 1}));
                 c = keyPair.$doPrivate(m);
             } else {
@@ -22,6 +23,7 @@ module.exports = function (keyPair, options) {
 
             if (usePublic) {
                 m = keyPair.$doPublic(c);
+                /* Type 1: zeros padding for private key decrypt */
                 return pkcs1Scheme.encUnPad(m.toBuffer(keyPair.encryptedDataLength), {type: 1});
             } else {
                 m = keyPair.$doPrivate(c);
diff --git a/src/schemes/pkcs1.js b/src/schemes/pkcs1.js
@@ -50,6 +50,7 @@ module.exports.makeScheme = function (key, options) {
             throw new Error("Message too long for RSA (n=" + this.key.encryptedDataLength + ", l=" + buffer.length + ")");
         }
 
+        /* Type 1: zeros padding for private key encrypt */
         if (options.type === 1) {
             filled = new Buffer(this.key.encryptedDataLength - buffer.length - 1);
             filled.fill(0xff, 0, filled.length - 1);
@@ -58,6 +59,7 @@ module.exports.makeScheme = function (key, options) {
 
             return Buffer.concat([filled, buffer]);
         } else {
+            /* random padding for public key encrypt */
             filled = new Buffer(this.key.encryptedDataLength - buffer.length);
             filled[0] = 0;
             filled[1] = 2;
@@ -88,6 +90,7 @@ module.exports.makeScheme = function (key, options) {
             return null;
         }
 
+        /* Type 1: zeros padding for private key decrypt */
         if (options.type === 1) {
             if (buffer[0] !== 0 && buffer[1] !== 1) {
                 return null;
@@ -99,6 +102,7 @@ module.exports.makeScheme = function (key, options) {
                 }
             }
         } else {
+            /* random padding for public key decrypt */
             if (buffer[0] !== 0 && buffer[1] !== 2) {
                 return null;
             }

Original file line number	Diff line number	Diff line change
`@@ -50,6 +50,7 @@ module.exports.makeScheme = function (key, options) {`
`50`	`50`	`throw new Error("Message too long for RSA (n=" + this.key.encryptedDataLength + ", l=" + buffer.length + ")");`
`51`	`51`	`}`
`52`	`52`
	`53`	`+ /* Type 1: zeros padding for private key encrypt */`
`53`	`54`	`if (options.type === 1) {`
`54`	`55`	`filled = new Buffer(this.key.encryptedDataLength - buffer.length - 1);`
`55`	`56`	`filled.fill(0xff, 0, filled.length - 1);`
`@@ -58,6 +59,7 @@ module.exports.makeScheme = function (key, options) {`
`58`	`59`
`59`	`60`	`return Buffer.concat([filled, buffer]);`
`60`	`61`	`} else {`
	`62`	`+ /* random padding for public key encrypt */`
`61`	`63`	`filled = new Buffer(this.key.encryptedDataLength - buffer.length);`
`62`	`64`	`filled[0] = 0;`
`63`	`65`	`filled[1] = 2;`
`@@ -88,6 +90,7 @@ module.exports.makeScheme = function (key, options) {`
`88`	`90`	`return null;`
`89`	`91`	`}`
`90`	`92`
	`93`	`+ /* Type 1: zeros padding for private key decrypt */`
`91`	`94`	`if (options.type === 1) {`
`92`	`95`	`if (buffer[0] !== 0 && buffer[1] !== 1) {`
`93`	`96`	`return null;`
`@@ -99,6 +102,7 @@ module.exports.makeScheme = function (key, options) {`
`99`	`102`	`}`
`100`	`103`	`}`
`101`	`104`	`} else {`
	`105`	`+ /* random padding for public key decrypt */`
`102`	`106`	`if (buffer[0] !== 0 && buffer[1] !== 2) {`
`103`	`107`	`return null;`
`104`	`108`	`}`