LayoutParams casting issue when recycling state

James O'Brien · James O'Brien · commit 8c4e5dffe120 · 2014-05-21T11:26:25.000-04:00
If the StaggeredGridView has a headerview but no content there will a casting exception when casting
AbsListView.LayoutParams to StaggeredGridView.LayoutParams. This patch set confirms that the params
are an instance of StaggeredGridView.LayoutParams before proceeding.
diff --git a/library/src/main/java/com/etsy/android/grid/ExtendableListView.java b/library/src/main/java/com/etsy/android/grid/ExtendableListView.java
@@ -2593,9 +2593,10 @@ private void clearRecycledState(ArrayList<FixedViewInfo> infos) {
         if (infos == null) return;
         for (FixedViewInfo info : infos) {
             final View child = info.view;
-            final LayoutParams p = (LayoutParams) child.getLayoutParams();
-            if (p != null) {
-                p.recycledHeaderFooter = false;
+            final ViewGroup.LayoutParams p = child.getLayoutParams();
+
+            if (p instanceof LayoutParams) {
+                ((LayoutParams) p).recycledHeaderFooter = false;
             }
         }
     }

Original file line number	Diff line number	Diff line change
`@@ -2593,9 +2593,10 @@ private void clearRecycledState(ArrayList<FixedViewInfo> infos) {`
`2593`	`2593`	`if (infos == null) return;`
`2594`	`2594`	`for (FixedViewInfo info : infos) {`
`2595`	`2595`	`final View child = info.view;`
`2596`		`- final LayoutParams p = (LayoutParams) child.getLayoutParams();`
`2597`		`- if (p != null) {`
`2598`		`- p.recycledHeaderFooter = false;`
	`2596`	`+ final ViewGroup.LayoutParams p = child.getLayoutParams();`
	`2597`	`+`
	`2598`	`+ if (p instanceof LayoutParams) {`
	`2599`	`+ ((LayoutParams) p).recycledHeaderFooter = false;`
`2599`	`2600`	`}`
`2600`	`2601`	`}`
`2601`	`2602`	`}`