Skip to content

Commit 1db3be4

Browse files
thopiekarinclement
authored andcommitted
Correcting check for libtool
It is correct that we need libtool, but the executable is called libtoolize. Therefore sh.which(executable) won't work in this case. I renamed the variable "tool" to "executable", so other developers won't get confused and also add package names here.
1 parent 382eadf commit 1db3be4

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

pythonforandroid/toolchain.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -859,11 +859,11 @@ def prepare_build_environment(self, user_sdk_dir, user_ndk_dir,
859859

860860
# AND: Are these necessary? Where to check for and and ndk-build?
861861
# check the basic tools
862-
for tool in ("pkg-config", "autoconf", "automake", "libtool",
862+
for executable in ("pkg-config", "autoconf", "automake", "libtoolize",
863863
"tar", "bzip2", "unzip", "make", "gcc", "g++"):
864-
if not sh.which(tool):
865-
warning("Missing requirement: {} is not installed".format(
866-
tool))
864+
if not sh.which(executable):
865+
warning("Missing executable: {} is not installed".format(
866+
executable))
867867

868868
if not ok:
869869
sys.exit(1)

0 commit comments

Comments
 (0)