Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"Selected folder must be empty" after resetting to default #1407

Open
2 tasks done
xhalo32 opened this issue Nov 30, 2024 · 1 comment
Open
2 tasks done

"Selected folder must be empty" after resetting to default #1407

xhalo32 opened this issue Nov 30, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@xhalo32
Copy link

xhalo32 commented Nov 30, 2024

Before submitting an issue, please check the following

  • I have searched for similar issues (both open and closed) and cannot find a duplicate
  • I agree to follow the Code of Conduct

Describe the bug

I tried to change to a custom saber folder, but it won't change back using the reset button due to an error: "Selected folder must be empty".

To reproduce

  1. I created a folder on the device and export a saber document as sba there.
  2. I changed "Custom Saber folder" to that folder.
  3. I tried to import the sba file (after removing the .bin suffix) I had just exported which failed for no apparent reason. (Also I'm unable to create new saber documents now.)
  4. I restarted the application
  5. I tried to revert step 1 by clicking the reset button in the "Custom Saber folder" dialog.
  6. The application refused and I lost all my notes :(

Expected behavior

I expected step 4 (resetting "Custom Saber folder") to work.

I also expect saber to not be in an unusable state (I cannot create new notes or open old ones)

Saber version

v0.25.2 F-Droid (25020)

Device

  • Device: Samsung Galaxy Tab S8+ (SM-X800)
  • OS: Android 14

Anything else?

I can add a screen recording of the state things are now, but I (probably) can't replicate the bug without losing all my notes. Any help would be appreciated!
@xhalo32 xhalo32 added the bug Something isn't working label Nov 30, 2024
@xhalo32
Copy link
Author

xhalo32 commented Nov 30, 2024 •
edited
Loading

I just noticed the logs, and they say

PathAccessException: Cannot open file, path = '/storage/emulated/0/Android/media.com.github.catfriend1.syncthingandroid/Saber/note.sbn2' (OS Error: Operation not permitted, errno = 1)

Maybe using syncthing as a custom saber working directory triggers the bug?

Also note: I am able to make new directories from the "Browse" tab, just saving notes causes the exception.

Tip: It would probably be wise to persist the logs between restarts, as there's no way to see them after getting stuck inside the note unable to save or go to the main menu.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@xhalo32