Update PasswordGen.java

arrnavvv · web-flow · commit ebdf7bede8d6 · 2020-09-18T11:31:47.000+05:30
diff --git a/Others/PasswordGen.java b/Others/PasswordGen.java
@@ -35,13 +35,13 @@ static String generatePassword(int min_length, int max_length) {
 
         // Inbuilt method to randomly shuffle a elements of a list
         Collections.shuffle(letters);
-        String password = "";
+       StringBuilder password = new StringBuilder();
 
         // Note that size of the password is also random
         for (int i = random.nextInt(max_length - min_length) + min_length; i > 0; --i) {
-            password += letters.get(random.nextInt(letters.size()));
+            password .append( letters.get(random.nextInt(letters.size())));
         }
 
-        return password;
+        return password.toString();
     }
 }

Original file line number	Diff line number	Diff line change
`@@ -35,13 +35,13 @@ static String generatePassword(int min_length, int max_length) {`
`35`	`35`
`36`	`36`	`// Inbuilt method to randomly shuffle a elements of a list`
`37`	`37`	`Collections.shuffle(letters);`
`38`		`- String password = "";`
	`38`	`+ StringBuilder password = new StringBuilder();`
`39`	`39`
`40`	`40`	`// Note that size of the password is also random`
`41`	`41`	`for (int i = random.nextInt(max_length - min_length) + min_length; i > 0; --i) {`
`42`		`- password += letters.get(random.nextInt(letters.size()));`
	`42`	`+ password .append( letters.get(random.nextInt(letters.size())));`
`43`	`43`	`}`
`44`	`44`
`45`		`- return password;`
	`45`	`+ return password.toString();`
`46`	`46`	`}`
`47`	`47`	`}`