added 23503 pgerrcode support and updated the error conversion approach (go-gorm#185)

amirejaz75 · web-flow · commit b320a5cdf7d6 · 2023-05-19T18:35:13.000+08:00
* added 23503 pgerrcode support and updated the error conversion approach

* updated to meaningful variables names
diff --git a/error_translator.go b/error_translator.go
@@ -6,8 +6,9 @@ import (
 	"gorm.io/gorm"
 )
 
-var errCodes = map[string]string{
-	"uniqueConstraint": "23505",
+var errDesToGormErrs = map[string]error{
+	"23505": gorm.ErrDuplicatedKey,
+	"23503": gorm.ErrForeignKeyViolated,
 }
 
 type ErrMessage struct {
@@ -20,8 +21,9 @@ type ErrMessage struct {
 // Since currently gorm supporting both pgx and pg drivers, only checking for pgx PgError types is not enough for translating errors, so we have additional error json marshal fallback.
 func (dialector Dialector) Translate(err error) error {
 	if pgErr, ok := err.(*pgconn.PgError); ok {
-		if pgErr.Code == errCodes["uniqueConstraint"] {
-			return gorm.ErrDuplicatedKey
+		gormErr, ok := errDesToGormErrs[pgErr.Code]
+		if ok {
+			return gormErr
 		}
 		return err
 	}

Original file line number	Diff line number	Diff line change
`@@ -6,8 +6,9 @@ import (`
`6`	`6`	`"gorm.io/gorm"`
`7`	`7`	`)`
`8`	`8`
`9`		`-var errCodes = map[string]string{`
`10`		`- "uniqueConstraint": "23505",`
	`9`	`+var errDesToGormErrs = map[string]error{`
	`10`	`+ "23505": gorm.ErrDuplicatedKey,`
	`11`	`+ "23503": gorm.ErrForeignKeyViolated,`
`11`	`12`	`}`
`12`	`13`
`13`	`14`	`type ErrMessage struct {`
`@@ -20,8 +21,9 @@ type ErrMessage struct {`
`20`	`21`	`// Since currently gorm supporting both pgx and pg drivers, only checking for pgx PgError types is not enough for translating errors, so we have additional error json marshal fallback.`
`21`	`22`	`func (dialector Dialector) Translate(err error) error {`
`22`	`23`	`if pgErr, ok := err.(*pgconn.PgError); ok {`
`23`		`- if pgErr.Code == errCodes["uniqueConstraint"] {`
`24`		`- return gorm.ErrDuplicatedKey`
	`24`	`+ gormErr, ok := errDesToGormErrs[pgErr.Code]`
	`25`	`+ if ok {`
	`26`	`+ return gormErr`
`25`	`27`	`}`
`26`	`28`	`return err`
`27`	`29`	`}`