Merge pull request egonSchiele#161 from ZGennadiy/fix_es6_selection_sort

egonSchiele · web-flow · commit 0c8dc34e9321 · 2020-09-14T10:55:10.000-05:00
Update selection sort ES6 for keep original array immutable
diff --git a/02_selection_sort/ES6/01_selection_sort.js b/02_selection_sort/ES6/01_selection_sort.js
@@ -19,17 +19,21 @@ const findSmallestIndex = (array) => {
 
 // 2. Sorts the array
 const selectionSort = (array) => {
+  //Copy values from array, because it must be immutable. Without that after call selectionSort origin array will become empty.
+  const sortingArray = [...array];
   const sortedArray = [];
-  const length = array.length;
+  const length = sortingArray.length;
 
   for (let i = 0; i < length; i++) {
     // Finds the smallest element in the given array 
-    const smallestIndex = findSmallestIndex(array);
+    const smallestIndex = findSmallestIndex(sortingArray);
     // Adds the smallest element to new array
-    sortedArray.push(array.splice(smallestIndex, 1)[0]);
+    sortedArray.push(sortingArray.splice(smallestIndex, 1)[0]);
   }
 
   return sortedArray;
 };
 
-console.log(selectionSort([5, 3, 6, 2, 10])); // [2, 3, 5, 6, 10]
+const array = [5, 3, 6, 2, 10];
+console.log(selectionSort(array)); // [2, 3, 5, 6, 10]
+console.log(array); // [5, 3, 6, 2, 10]
