removed broken optimization

neelance · neelance · commit d0f48757b9b1 · 2015-03-17T02:13:28.000+01:00
diff --git a/compiler/analysis/escape.go b/compiler/analysis/escape.go
@@ -50,12 +50,6 @@ type escapingObjectCollector struct {
 func (v *escapingObjectCollector) Visit(node ast.Node) (w ast.Visitor) {
 	if id, ok := node.(*ast.Ident); ok {
 		if obj, ok := v.analysis.info.Uses[id].(*types.Var); ok {
-			switch obj.Type().Underlying().(type) {
-			case *types.Struct, *types.Array:
-				// always by reference
-				return nil
-			}
-
 			for s := obj.Parent(); s != nil; s = s.Parent() {
 				if s == v.analysis.topScope {
 					v.analysis.escaping[obj] = true
diff --git a/tests/misc_test.go b/tests/misc_test.go
@@ -226,6 +226,23 @@ func TestLoopClosure(t *testing.T) {
 	}
 }
 
+func TestLoopClosureWithStruct(t *testing.T) {
+	type T struct{ A int }
+	ts := []T{{0}, {1}, {2}}
+	fns := make([]func() T, 3)
+	for i, t := range ts {
+		t := t
+		fns[i] = func() T {
+			return t
+		}
+	}
+	for i := range fns {
+		if fns[i]().A != i {
+			t.Fail()
+		}
+	}
+}
+
 func TestNilInterfaceError(t *testing.T) {
 	defer func() {
 		if err := recover(); err == nil || !strings.Contains(err.(error).Error(), "nil pointer dereference") {
