Skip to content

Update sbt-scalajs, ... to 1.6.0 #462

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Update sbt-scalajs, ... to 1.6.0 #462

wants to merge 1 commit into from

Conversation

scala-steward
Copy link
Contributor

Updates

from 1.5.1 to 1.6.0.
GitHub Release Notes - Version Diff

I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.

If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.

Configure Scala Steward for your repository with a .scala-steward.conf file.

Have a fantastic day writing Scala!

Files still referring to the old version number

The following files still refer to the old version number (1.5.1).
You might want to review and update them manually.

.scalafmt.conf
admin/scalafmt.sh
Ignore future updates

Add this to your .scala-steward.conf file to ignore future updates of this dependency:

updates.ignore = [ { groupId = "org.scala-js" } ]

labels: library-update, semver-minor, old-version-remains

@xuwei-k xuwei-k mentioned this pull request Jun 9, 2021
Closed
@xuwei-k
Copy link
Contributor

xuwei-k commented Jun 9, 2021

🤔 @sjrd

https://travis-ci.com/github/scala/scala-collection-compat/jobs/512124925

[error] Test test.scala.collection.ArraySeqTest.slice failed: org.scalajs.linker.runtime.UndefinedBehaviorError: java.lang.ClassCastException: [V@a is not an instance of Ljava.lang.Object;, took 0.008 sec
[error]     at <jscode>.$throwClassCastException(/home/travis/build/scala/scala-collection-compat/.cross/compat212/js/target/scala-2.12/scala-collection-compat-test-fastopt/main.js:52)
[error]     at <jscode>.$throwArrayCastException(/home/travis/build/scala/scala-collection-compat/.cross/compat212/js/target/scala-2.12/scala-collection-compat-test-fastopt/main.js:58)
[error]     at <jscode>.$asArrayOf_O(/home/travis/build/scala/scala-collection-compat/.cross/compat212/js/target/scala-2.12/scala-collection-compat-test-fastopt/main.js:891)
[error]     at scala.collection.mutable.WrappedArray$.make(/home/travis/build/scala/scala-collection-compat/.cross/compat212/js/target/scala-2.12/scala-collection-compat-test-fastopt/main.js:10415)
[error]     at scala.collection.mutable.WrappedArrayBuilder.mkArray(/home/travis/build/scala/scala-collection-compat/.cross/compat212/js/target/scala-2.12/scala-collection-compat-test-fastopt/main.js:53325)
[error]     at scala.collection.mutable.WrappedArrayBuilder.result(/home/travis/build/scala/scala-collection-compat/.cross/compat212/js/target/scala-2.12/scala-collection-compat-test-fastopt/main.js:53469)
[error]     at scala.collection.mutable.WrappedArrayBuilder.result(/home/travis/build/scala/scala-collection-compat/.cross/compat212/js/target/scala-2.12/scala-collection-compat-test-fastopt/main.js:53473)
[error]     at scala.collection.mutable.Builder$$anon$1.result(/home/travis/build/scala/scala-collection-compat/.cross/compat212/js/target/scala-2.12/scala-collection-compat-test-fastopt/main.js:52735)
[error]     at test.scala.collection.ArraySeqTest.slice(/home/travis/build/scala/scala-collection-compat/.cross/compat212/js/target/scala-2.12/scala-collection-compat-test-fastopt/main.js:26131)
[error]     at test.scala.collection.ArraySeqTest$scalajs$junit$bootstrapper$.invokeTest(/home/travis/build/scala/scala-collection-compat/.cross/compat212/js/target/scala-2.12/scala-collection-compat-test-fastopt/main.js:41192)
[error] Caused by: java.lang.ClassCastException: [V@a is not an instance of Ljava.lang.Object;
[error]     ... 10 more
[error] Failed: Total 212, Failed 1, Errors 0, Passed 210, Skipped 1
[error] Failed tests:
[error] 	test.scala.collection.ArraySeqTest
[error] (compat212JS / Test / test) sbt.TestsFailedException: Tests unsuccessful

@sjrd
Copy link
Member

sjrd commented Jun 9, 2021

Ouch. That's a bug in Scala.js. Apparently we failed to port scala/scala@5e6676d to our Scala.js-specific version of ClassTag. That fixed a regression introduced in scala/scala#9091, which touches files that we inherit from Scala core, without having a Scala.js-specific one. So we inherited the regression, but not the fix for the regression.

The upgrade to 1.6.0 surfaced the issue because it is only in 1.6.0 that we upgraded our Scala standard library to 2.12.13.

I will follow up with a bug report and a fix in Scala.js later today.

I guess this repo will have to skip Scala.js 1.6.0. I don't see a way around it.

@sjrd sjrd mentioned this pull request Jun 9, 2021
Closed
@SethTisue SethTisue closed this Jun 9, 2021
@scala-steward scala-steward deleted the update/sbt-scalajs-1.6.0 branch June 16, 2021 23:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@scala-steward @xuwei-k @sjrd @SethTisue