Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test cases project for presentation compiler #22101

Merged
merged 2 commits into from
Dec 4, 2024

Conversation

mbovel
Copy link
Member

@mbovel mbovel commented Dec 3, 2024

This PR adds a mechanism to test the presentation compiler with snippets using arbitrary pre-compiled files. To do so, it adds a new project scala3-presentation-compiler-testcases, compiled with the bootstrapped compiler, which is used as a dependency of scala3-presentation-compiler. The resulting class path is added to the ideTestsDependencyClasspath build info so that the test cases can be used from the presentation compiler tests.

This PR also adds a test case for #20560. It shows that there is no hover info for the resulting type of a transparent inline macro when it fails to execute. However, the macro succeeds when loading the class java.sql.Driver, so that still doesn't tell us what the problem is with #20560

Copy link
Contributor

@rochala rochala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice addition to have

@mbovel mbovel merged commit 6a08590 into scala:main Dec 4, 2024
29 checks passed
@mbovel mbovel deleted the mb/presentation-compiler-testcases branch December 4, 2024 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants