Introduce build-level vals for the default Scala versions.

sjrd · sjrd · commit ecb47df58dd2 · 2021-07-07T23:55:46.000+02:00
This avoids repeating them in several places the build, potentially
creating mismatches.
diff --git a/project/Build.scala b/project/Build.scala
@@ -242,6 +242,13 @@ object Build {
     isGeneratingForIDE
   }
 
+  import MultiScalaProject.{
+    Default2_11ScalaVersion,
+    Default2_12ScalaVersion,
+    Default2_13ScalaVersion,
+    DefaultScalaVersion
+  }
+
   val scalastyleCheck = taskKey[Unit]("Run scalastyle")
 
   val fetchScalaSource = taskKey[File](
@@ -258,7 +265,7 @@ object Build {
   val previousBinaryCrossVersion = CrossVersion.binaryWith("sjs1_", "")
 
   val scalaVersionsUsedForPublishing: Set[String] =
-    Set("2.11.12", "2.12.14", "2.13.6")
+    Set(Default2_11ScalaVersion, Default2_12ScalaVersion, Default2_13ScalaVersion)
   val newScalaBinaryVersionsInThisRelease: Set[String] =
     Set()
 
@@ -870,7 +877,7 @@ object Build {
       MyScalaJSPlugin
   ).settings(
       commonSettings,
-      scalaVersion := "2.12.14",
+      scalaVersion := DefaultScalaVersion,
       fatalWarningsSettings,
       name := "Scala.js linker private library",
       publishArtifact in Compile := false,
@@ -1062,7 +1069,7 @@ object Build {
       name := "Scala.js sbt plugin",
       normalizedName := "sbt-scalajs",
       sbtPlugin := true,
-      crossScalaVersions := Seq("2.12.14"),
+      crossScalaVersions := Seq(DefaultScalaVersion),
       scalaVersion := crossScalaVersions.value.head,
       sbtVersion := "1.0.0",
       scalaBinaryVersion :=
@@ -1682,23 +1689,23 @@ object Build {
 
       MyScalaJSPlugin.expectedSizes := {
         scalaVersion.value match {
-          case "2.11.12" =>
+          case Default2_11ScalaVersion =>
             Some(ExpectedSizes(
                 fastLink = 520000 to 521000,
                 fullLink = 108000 to 109000,
                 fastLinkGz = 66000 to 67000,
                 fullLinkGz = 28000 to 29000,
             ))
 
-          case "2.12.14" =>
+          case Default2_12ScalaVersion =>
             Some(ExpectedSizes(
                 fastLink = 782000 to 783000,
                 fullLink = 150000 to 151000,
                 fastLinkGz = 92000 to 93000,
                 fullLinkGz = 36000 to 37000,
             ))
 
-          case "2.13.6" =>
+          case Default2_13ScalaVersion =>
             Some(ExpectedSizes(
                 fastLink = 777000 to 778000,
                 fullLink = 169000 to 170000,
diff --git a/project/MultiScalaProject.scala b/project/MultiScalaProject.scala
@@ -83,6 +83,15 @@ object MultiScalaProject {
     "2.13" -> Seq("2.13.0", "2.13.1", "2.13.2", "2.13.3", "2.13.4", "2.13.5", "2.13.6"),
   )
 
+  val Default2_11ScalaVersion = versions("2.11").last
+  val Default2_12ScalaVersion = versions("2.12").last
+  val Default2_13ScalaVersion = versions("2.13").last
+
+  /** The default Scala version is the default 2.12 Scala version, because it
+   *  must work for sbt plugins.
+   */
+  val DefaultScalaVersion = Default2_12ScalaVersion
+
   private final val ideVersion = "2.12"
 
   private def projectID(id: String, major: String) = id + major.replace('.', '_')
