From bcfd017aff1e53ad782a24fa586db2716135ea4c Mon Sep 17 00:00:00 2001 From: Arman Bilge Date: Wed, 11 Aug 2021 01:41:59 +0000 Subject: [PATCH 1/2] Fix #445 return type for Header#get --- src/main/scala/org/scalajs/dom/experimental/Fetch.scala | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/main/scala/org/scalajs/dom/experimental/Fetch.scala b/src/main/scala/org/scalajs/dom/experimental/Fetch.scala index 42064db9c..c05457f48 100644 --- a/src/main/scala/org/scalajs/dom/experimental/Fetch.scala +++ b/src/main/scala/org/scalajs/dom/experimental/Fetch.scala @@ -309,7 +309,7 @@ class Headers(map: HeadersInit = js.Array[js.Array[String]]()) * * @param name a ByteString, ie. only ASCII chars */ - def get(name: ByteString): js.UndefOr[ByteString] = js.native + def get(name: ByteString): ByteString = js.native /** * The getAll() method of the Headers interface returns an array of all the From f6a8e6a636c7ae5e27962ff43a699717d65746b5 Mon Sep 17 00:00:00 2001 From: Arman Bilge Date: Thu, 12 Aug 2021 23:39:22 +0000 Subject: [PATCH 2/2] prePR --- api-reports/2_12.txt | 2 +- api-reports/2_13.txt | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/api-reports/2_12.txt b/api-reports/2_12.txt index 4a975c2a0..7d355e6ca 100644 --- a/api-reports/2_12.txt +++ b/api-reports/2_12.txt @@ -252,7 +252,7 @@ experimental/Fullscreen.FullscreenDocument[JT] var onfullscreenerror: js.Functio experimental/Fullscreen.FullscreenElement[JT] def requestFullscreen(): js.UndefOr[js.Promise[Unit]] experimental/Headers[JC] def append(name: ByteString, value: ByteString): Unit experimental/Headers[JC] def delete(name: ByteString): Unit -experimental/Headers[JC] def get(name: ByteString): js.UndefOr[ByteString] +experimental/Headers[JC] def get(name: ByteString): ByteString experimental/Headers[JC] def getAll(name: ByteString): Sequence[ByteString] experimental/Headers[JC] def has(name: ByteString): Boolean experimental/Headers[JC] @JSName(js.Symbol.iterator) def jsIterator(): js.Iterator[js.Array[ByteString]] diff --git a/api-reports/2_13.txt b/api-reports/2_13.txt index c2030e587..db3e6f27f 100644 --- a/api-reports/2_13.txt +++ b/api-reports/2_13.txt @@ -252,7 +252,7 @@ experimental/Fullscreen.FullscreenDocument[JT] var onfullscreenerror: js.Functio experimental/Fullscreen.FullscreenElement[JT] def requestFullscreen(): js.UndefOr[js.Promise[Unit]] experimental/Headers[JC] def append(name: ByteString, value: ByteString): Unit experimental/Headers[JC] def delete(name: ByteString): Unit -experimental/Headers[JC] def get(name: ByteString): js.UndefOr[ByteString] +experimental/Headers[JC] def get(name: ByteString): ByteString experimental/Headers[JC] def getAll(name: ByteString): Sequence[ByteString] experimental/Headers[JC] def has(name: ByteString): Boolean experimental/Headers[JC] @JSName(js.Symbol.iterator) def jsIterator(): js.Iterator[js.Array[ByteString]]