MAINT Added Parameter Validation for metrics.make_scorer (#25760)

ZeeshanLone · jeremiedbb · web-flow · commit 20ad9cd62cbe · 2023-03-06T23:33:38.000+01:00
Co-authored-by: Jérémie du Boisberranger &lt;34657725+jeremiedbb@users.noreply.github.com&gt;
diff --git a/sklearn/metrics/_scorer.py b/sklearn/metrics/_scorer.py
@@ -608,6 +608,14 @@ def _check_multimetric_scoring(estimator, scoring):
     return scorers
 
 
+@validate_params(
+    {
+        "score_func": [callable],
+        "greater_is_better": ["boolean"],
+        "needs_proba": ["boolean"],
+        "needs_threshold": ["boolean"],
+    }
+)
 def make_scorer(
     score_func,
     *,
diff --git a/sklearn/tests/test_public_functions.py b/sklearn/tests/test_public_functions.py
@@ -135,6 +135,7 @@ def _check_function_param_validation(
     "sklearn.metrics.jaccard_score",
     "sklearn.metrics.label_ranking_loss",
     "sklearn.metrics.log_loss",
+    "sklearn.metrics.make_scorer",
     "sklearn.metrics.matthews_corrcoef",
     "sklearn.metrics.max_error",
     "sklearn.metrics.mean_absolute_error",
