Skip to content

Commit 34596c6

Browse files
committed
Fixing gael's comments
1 parent 921ab38 commit 34596c6

File tree

3 files changed

+4
-11
lines changed

3 files changed

+4
-11
lines changed

benchmarks/bench_saga.py

-1
Original file line numberDiff line numberDiff line change
@@ -160,7 +160,6 @@ def exp(solvers, penalty, single_target,
160160
X = X[:n_samples]
161161
y = y[:n_samples]
162162

163-
# cached_fit = mem.cache(fit_single)
164163
out = Parallel(n_jobs=n_jobs, mmap_mode=None)(
165164
delayed(fit_single)(solver, X, y,
166165
penalty=penalty, single_target=single_target,

sklearn/linear_model/logistic.py

+4
Original file line numberDiff line numberDiff line change
@@ -1197,6 +1197,10 @@ def fit(self, X, y, sample_weight=None):
11971197
Returns
11981198
-------
11991199
self : object
1200+
1201+
Notes
1202+
-----
1203+
The SAGA solver supports both float64 and float32 bit arrays.
12001204
"""
12011205
if not isinstance(self.C, numbers.Number) or self.C < 0:
12021206
raise ValueError("Penalty term must be positive; got (C=%r)"

sklearn/linear_model/sag_fast.pyx.tp

-10
Original file line numberDiff line numberDiff line change
@@ -267,16 +267,6 @@ def sag{{name}}(SequentialDataset{{name}} dataset,
267267
cdef {{c_type}} y
268268
# the sample weight
269269
cdef {{c_type}} sample_weight
270-
# # _step_size
271-
# cdef {{c_type}} _step_size = <{{c_type}}> __step_size
272-
# # alpha
273-
# cdef {{c_type}} alpha = <{{c_type}}> _alpha
274-
# # beta
275-
# cdef {{c_type}} beta = <{{c_type}}> _beta
276-
# # tol
277-
# cdef {{c_type}} tol = <{{c_type}}> _tol
278-
# # intercept_decay
279-
# cdef {{c_type}} intercept_decay = <{{c_type}}> _intercept_decay
280270

281271
# helper variable for indexes
282272
cdef int f_idx, s_idx, feature_ind, class_ind, j

0 commit comments

Comments
 (0)