Skip to content

Commit 525b48c

Browse files
author
ciku
committed
fix validate parameters in fit for # KernelPCA,
1 parent 74bf394 commit 525b48c

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

sklearn/decomposition/_kernel_pca.py

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -257,8 +257,6 @@ def __init__(
257257
copy_X=True,
258258
n_jobs=None,
259259
):
260-
if fit_inverse_transform and kernel == "precomputed":
261-
raise ValueError("Cannot fit_inverse_transform with a precomputed kernel.")
262260
self.n_components = n_components
263261
self.kernel = kernel
264262
self.kernel_params = kernel_params
@@ -434,6 +432,9 @@ def fit(self, X, y=None):
434432
K = self._get_kernel(X)
435433
self._fit_transform(K)
436434

435+
if self.fit_inverse_transform and self.kernel == "precomputed":
436+
raise ValueError("Cannot fit_inverse_transform with a precomputed kernel.")
437+
437438
if self.fit_inverse_transform:
438439
# no need to use the kernel to transform X, use shortcut expression
439440
X_transformed = self.eigenvectors_ * np.sqrt(self.eigenvalues_)

sklearn/tests/test_common.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -410,7 +410,6 @@ def test_transformers_get_feature_names_out(transformer):
410410
"FeatureUnion",
411411
"GridSearchCV",
412412
"HalvingGridSearchCV",
413-
"KernelPCA",
414413
"Pipeline",
415414
"SGDOneClassSVM",
416415
"TheilSenRegressor",

0 commit comments

Comments
 (0)